✨Autofocus on show()
#20687
Merged
✨Autofocus on show()
#20687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aghassemi
reviewed
Feb 6, 2019
src/service/standard-actions-impl.js
Outdated
| const autofocusElOrNull = getAutofocusElementForShowAction(target); | ||
|
|
||
| // Safari only honors focus in sync operations. | ||
| if (autofocusElOrNull && Services.platformFor(ownerWindow).isSafari()) { |
There was a problem hiding this comment.
Check for iOS instead, it is an iOS thing (I don't think isSafari catches Chrome on iOS for example)
aghassemi
approved these changes
Feb 6, 2019
nbeloglazov
pushed a commit
to nbeloglazov/amphtml
that referenced
this pull request
Feb 12, 2019
## Breakdown
- Autofocuses optional `[autofocus]` element in the displayed tree via `show`/`toggle`.
- Forces synchronous display-focus chain on iOS so that programmatic focus is honored.
## Usage
```html
<button on="tap: wrapper.show">
Show
</button>
<div id="wrapper" hidden>
<input type="text" autofocus>
</div>
```
## etc.
Demo: <https://amp-autofocus.glitch.me/>
Closes ampproject#19949.
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
## Breakdown
- Autofocuses optional `[autofocus]` element in the displayed tree via `show`/`toggle`.
- Forces synchronous display-focus chain on iOS so that programmatic focus is honored.
## Usage
```html
<button on="tap: wrapper.show">
Show
</button>
<div id="wrapper" hidden>
<input type="text" autofocus>
</div>
```
## etc.
Demo: <https://amp-autofocus.glitch.me/>
Closes ampproject#19949.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breakdown
[autofocus]inside the displayed tree viashow/toggle.Usage
etc.
Demo: https://amp-autofocus.glitch.me/
Closes #19949.