Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Error: Received user action in non-visible doc #28908

Closed
ampprojectbot opened this issue Jun 16, 2020 · 6 comments · Fixed by #29379
Closed

🚨 Error: Received user action in non-visible doc #28908

ampprojectbot opened this issue Jun 16, 2020 · 6 comments · Fixed by #29379
Assignees
Labels
P1: High Priority Type: Error Report An error reported by AMP Error Reporting

Comments

@ampprojectbot
Copy link
Member

Details

Error report: link
First seen: Jun 16, 2020
Frequency: ~ 4,932/day

Stacktrace

Error: Received user action in non-visible doc
    at Error (src/log.js:710:16)
    at createErrorVargs (src/log.js:315:20)
    at apply (src/log.js:330:18)
    at dev (src/service/viewer-impl.js:898:6)
    at localListener (src/event-helper-listen.js:58:13)

Notes

@dvoytenko modified src/log.js:709-723 in #2597 (Mar 15, 2016)
@rsimha modified src/log.js:315-318 in #21212 (May 16, 2019)
@erwinmombay modified src/log.js:330-331 in #6581 (Dec 20, 2016)
@cramforce modified src/service/viewer-impl.js:883-910 in #28807 (Jun 15, 2020)
@rsimha modified src/event-helper-listen.js:57-59 in #12450 (Dec 13, 2017)

Seen in:

  • 06-15 Nightly (2249)

Possible assignees: @cramforce

/cc @ampproject/release-on-duty

@ampprojectbot ampprojectbot added the Type: Error Report An error reported by AMP Error Reporting label Jun 16, 2020
@zhouyx
Copy link
Contributor

zhouyx commented Jun 16, 2020

This is a new error from nightly build with a high frequency. Related to #28227. Seems to be a new dev error that got surfaced because we started to collect it.

cc @gmajoulet @cramforce

@cramforce
Copy link
Member

This may be WAI. It would be important to investigate what documents using which viewer are triggering this.

Depending on the outcome we might either want to fix actual bugs this uncovered or turn it into an expected error.

@cramforce
Copy link
Member

The right way forward is probably

  • Verify that this isn't breaking anything.
  • In that case, turn the error into an expected error, and start tracking
  • File issues for the underlying issues

@ericfs
Copy link

ericfs commented Jun 16, 2020

Filed b/159160175 and b/159160175 for Google AMP Viewers.

@gmajoulet gmajoulet removed their assignment Jun 17, 2020
@rcebulko
Copy link
Contributor

rcebulko commented Jul 6, 2020

The right way forward is probably

  • Verify that this isn't breaking anything.
  • In that case, turn the error into an expected error, and start tracking
  • File issues for the underlying issues

Have we verified this isn't breaking anything @ericfs ? If so I can take care of marking it as expected in an upcoming related PR

@ericfs
Copy link

ericfs commented Jul 13, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1: High Priority Type: Error Report An error reported by AMP Error Reporting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants