Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Stories more resilient to viewer communication initialization errors. #28227

Closed
gmajoulet opened this issue May 5, 2020 · 1 comment · Fixed by #28807
Closed

Make Stories more resilient to viewer communication initialization errors. #28227

gmajoulet opened this issue May 5, 2020 · 1 comment · Fixed by #28807
Assignees
@cramforce
Labels
P3: When Possible Type: Feature Request WG: stories

Comments

@gmajoulet
Copy link
Contributor

If a Viewer <> Story communication initialization fails, the Viewer can't switch the Story visibilitystate from prerender to visible after it is made visible, leaving users stuck on a completely unresponsive story.

We should improve this worst case scenario by making a trusted user gesture (tap/click) on a prerendered user story switch its visibilitystate to visible and proceed with the Story playback.

This change has been discussed with Google internal Privacy Working Group.

cc @ampproject/wg-stories
@gmajoulet gmajoulet self-assigned this May 5, 2020
@cramforce
Copy link
Member

Activating on interaction is a good idea.

@gmajoulet gmajoulet mentioned this issue May 20, 2020
Closed
@cramforce cramforce assigned cramforce and unassigned gmajoulet Jun 10, 2020
cramforce added a commit to cramforce/amphtml that referenced this issue Jun 10, 2020
@cramforce
Add a defense-in-depth to the viewer in case communication fails
333d647 
This will declare a doc to be visible if it isn't but gets a user action.

In Google Search this should never happen, because the doc isn't actually shown until the viewer handshake happened.

But other viewers do show documents right away.

Fixes ampproject#28227
@cramforce cramforce mentioned this issue Jun 10, 2020
Merged
cramforce added a commit to cramforce/amphtml that referenced this issue Jun 13, 2020
@cramforce
Add a defense-in-depth to the viewer in case communication fails
9f0cb54 
This will declare a doc to be visible if it isn't but gets a user action.

In Google Search this should never happen, because the doc isn't actually shown until the viewer handshake happened.

But other viewers do show documents right away.

Fixes ampproject#28227
cramforce added a commit that referenced this issue Jun 15, 2020
@cramforce
✨ Add a defense-in-depth to the viewer in case communication fails (#…
5ba7326 
…28807)

This will declare a doc to be visible if it isn't but gets a user action.

In Google Search this should never happen, because the doc isn't actually shown until the viewer handshake happened.

But other viewers do show documents right away.

Fixes #28227
@zhouyx zhouyx mentioned this issue Jun 16, 2020
Closed
mszylkowski pushed a commit to mszylkowski/amphtml that referenced this issue Jun 17, 2020
@cramforce @mszylkowski
✨ Add a defense-in-depth to the viewer in case communication fails (a…
bb972b4 
…mpproject#28807)

This will declare a doc to be visible if it isn't but gets a user action.

In Google Search this should never happen, because the doc isn't actually shown until the viewer handshake happened.

But other viewers do show documents right away.

Fixes ampproject#28227
@oliverfernandez oliverfernandez mentioned this issue Jul 31, 2020
Closed
@newmuis newmuis mentioned this issue Sep 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cramforce cramforce

Labels
P3: When Possible Type: Feature Request WG: stories
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Add a defense-in-depth to the viewer in case communication fails cramforce/amphtml
2 participants
@cramforce @gmajoulet