✨ Add a defense-in-depth to the viewer in case communication fails #28807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really like building this at the AMP level. This looks good to me. Privacy implications have been discussed and approved by an internal Privacy Working Group. |
dvoytenko
approved these changes
Jun 12, 2020
|
Overall this makes sense. But also depends a bit on a viewer. E.g. in case of Google Search, there was a glasspain on top of the doc that blocked all actions until the doc becomes visible. This, of course, wouldn't help those cases. |
This will declare a doc to be visible if it isn't but gets a user action. In Google Search this should never happen, because the doc isn't actually shown until the viewer handshake happened. But other viewers do show documents right away. Fixes ampproject#28227
cramforce
force-pushed
the
interactive-fallback
branch
from
333d647 to
4fa40e7
Compare
|
Thanks. Added tests |
gmajoulet
approved these changes
Jun 15, 2020
mszylkowski
pushed a commit
to mszylkowski/amphtml
that referenced
this pull request
Jun 17, 2020
…mpproject#28807) This will declare a doc to be visible if it isn't but gets a user action. In Google Search this should never happen, because the doc isn't actually shown until the viewer handshake happened. But other viewers do show documents right away. Fixes ampproject#28227
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will declare a doc to be visible if it isn't but gets a user action.
In Google Search this should never happen, because the doc isn't actually shown until the viewer handshake happened.
But other viewers do show documents right away, and we've seen cases where docs where presented to the user, but not interactive, because they never got the respective message.
Fixes #28227