🏗♻️ Split gulpfile.js into separate files
#22109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
It's difficult to review this file because I can't tell what are changes and what are just direct moves from gulpfile.js into the separate files. Would you mind telling us if there are any places where you made changes that aren't just moves and new/replaced imports?
|
@danielrozenberg Re: seeing code that has moved, read PR description. |
danielrozenberg
approved these changes
May 2, 2019
rsimha
commented
May 2, 2019
|
Locally tested the runtime (minified and not), and Travis is green. Merging. |
This was referenced May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits up
gulpfile.js(~1700 lines) into separate files for easy maintenance, and to pave the way for a long-awaited upgrade togulpv4.Since Github's web UI doesn't highlight code that was moved across files but is otherwise unchanged, you can check out this branch and run
git diff HEAD^ HEAD --color-moved. The only new code you should see arerequireandexportstatements.Coming up: Upgrade to
gulpv4