Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗♻️ Refactor / clean up the watch logic used for extensions #22659

Merged
merged 5 commits into from
Jun 3, 2019
Merged

🏗♻️ Refactor / clean up the watch logic used for extensions #22659

merged 5 commits into from
Jun 3, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Jun 3, 2019

This PR does the following:

Follow up to #47, #923, #1330, #3091, #12900, #12911, #13203, #13249, #17129, #22109, and #22635

@rsimha rsimha self-assigned this Jun 3, 2019
@rsimha rsimha requested a review from erwinmombay June 3, 2019 22:02
@rsimha
Copy link
Contributor Author

rsimha commented Jun 3, 2019

Tested as follows:

  • No errors while running gulp build
  • No errors while running gulp dist
    • experiments.js and amp-login-done-0.1.js are built as expected
  • No errors while running gulp
    • Modifying a non-extension .js file rebuilds the .js file exactly once
    • Modifying a .js file in an extension directory rebuilds the entire extension exactly once
    • Modifying a non-extension .css file copies all CSS to build/ and rebuilds amp.js exactly once
    • Modifying a .css file in an extension directory rebuilds the entire extension exactly once
  • No errors while running gulp --extensions amp-foo,amp-bar
    • Modifying .js and .css files in amp-foo or amp-bar results in the rebuilds described above
  • Runtime and extensions served correctly by gulp serve [--compiled]

@rsimha
Copy link
Contributor Author

rsimha commented Jun 3, 2019

Rebased on master, tested locally, Travis is green. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants