request for integrating adman ad-server #2 #2411

anmarkom · 2016-03-03T09:17:21Z

This PR provides support for ADMAN, the most widely used Ad Server in Greece. It is also used by publishers, advertisers and agencies in various other countries and serves many dozens of billions impressions per month.

I have signed CLA on behalf of Phaistos Networks S.A.

googlebot · 2016-03-03T09:17:22Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

anmarkom · 2016-03-03T14:51:26Z

I signed it!

cramforce · 2016-03-03T16:03:50Z

Please squash commits and this is good to go!

anmarkom · 2016-03-04T08:08:52Z

I've merged the commits. Thank you!

This blackholes them since nobody should ever use these in an ad.

* Adding postcss-import to the project * Adding amp-social-share extension

AMP Social Share Extension

Handle legacy alert, etc. in AMP ads.

And robustly handle the case that a Tweet has been deleted. Primary issue of ampproject#2530 Files ampproject#2536 because I realized we have no tests for the twitter widget.

Support placeholder for Tweets.

@jridgewell

@jridgewell is working on the real fix.

Quick fix for flakiness

Remove old docs directory and point to docs-site more clearly.

Updated amp-fill-content to workaround IOS

Minor afterEach fix on motion test

Don't parse src as an srcset

With this change, the other parts of URL are not touched when appending to the query parameters. Fixes ampproject#2245

This PR includes: - Removed comments from example for `atinternet`. Comments are not allowed in JSON. - Added example of `extraUrlParams` in `googleanalytics` and custom config examples. Fixes ampproject#1991. - Added `extraUrlParamsReplaceMap` for `googleanalytics`. The feature is used for (custom dimensions and metrics)[https://developers.google.com/analytics/devguides/collection/analyticsjs/custom-dims-mets]. - Pulled out `clientId` var. This allows publishers to override the value. Partly fixes ampproject#1940. Part 2 to follow. - Added trailing commas in a few places. - Moved GA from using `AMPDOC_URL` to `SOURCE_URL`. This improves the reports for GA that key off of document location.

Assorted fixes to amp-analytics

…play.

Viewer URL override support for login flow

Do not delete master frames on ads when there is no ad content to display

This will be a compiler error soon.

…n HTML test case. If you add the attribute `data-amp-report-test` to a tag, any errors emitted regarding that tag will have a new field dataAmpReportTestValue which will contain the attribute value set in the document. Example: `<!doctype lemur data-amp-report-test="foo">` results in a validationResult object whose errors array looks like: `errors[0].dataAmpReportTestValue -> 'foo'` Github ampproject#2600

Validator Roll-up

…closures alive.

anmarkom · 2016-03-28T10:46:34Z

@cramforce does it need anything else to be merged to master?

jridgewell · 2016-03-28T16:38:33Z

Assigning to @dvoytenko.

Make sure that holding on to unlisten handlers does not keep element/closures alive.

…tringy make global config testing non string

dvoytenko · 2016-03-28T17:31:46Z

@anmarkom You will also need to rebase your branch since it now has conflicts with master. Please do and I should be able to merge then.

Additional dependencies for amp-user-notifications and amp-analytics

This showed up benchmarking real world docs.

AMP jwplayer

Fixes ampproject#2730.

…-inactive Unselect text when marking document inactive

Layout documentation corrections

Change "it's URL" to "its URL" wherever it appears. No apostrophe should be used since this is not the possessive.

Used cached doc position in getLayoutRect.

Minor grammar mistake in documentation

provide example for adman amp-ad & more

cramforce added the LGTM label Mar 3, 2016

anmarkom force-pushed the adman branch from 1f8815b to b8684d2 Compare March 4, 2016 08:05

cramforce and others added 24 commits March 9, 2016 16:08

Handle legacy alert, etc. in AMP ads.

699810b

This blackholes them since nobody should ever use these in an ad.

Remove old docs directory and point to docs-site more clearly.

b1e1bb0

Implementing AMP Social Share Extension

519b3e8

* Adding postcss-import to the project * Adding amp-social-share extension

Merge pull request ampproject#1856 from paul-matthews/amp-social-share

b80230b

AMP Social Share Extension

Merge pull request ampproject#2522 from cramforce/no-alerts

9b29625

Handle legacy alert, etc. in AMP ads.

Support placeholder for Tweets.

5b8547c

And robustly handle the case that a Tweet has been deleted. Primary issue of ampproject#2530 Files ampproject#2536 because I realized we have no tests for the twitter widget.

Merge pull request ampproject#2537 from cramforce/twitter-deleted

496f420

Support placeholder for Tweets.

Quick fix for flakiness

6e2e40a

@jridgewell is working on the real fix.

Merge pull request ampproject#2538 from cramforce/css-flaky

2e0dd4c

Quick fix for flakiness

Merge pull request ampproject#2526 from cramforce/no-more-docs

d590b2c

Remove old docs directory and point to docs-site more clearly.

Merge pull request ampproject#2502 from omegdadi/issue2491

0c6528e

Updated amp-fill-content to workaround IOS

Minor afterEach fix on motion test

6d764f3

Merge pull request ampproject#2541 from dvoytenko/fixes56

b777b68

Minor afterEach fix on motion test

Viewer URL override support for login flow

b008bfa

Don't parse src as an srcset

17b8106

Merge pull request ampproject#2539 from dvoytenko/srcset3

0a4677a

Don't parse src as an srcset

Changed the way url params are added to a URL.

28e9136

With this change, the other parts of URL are not touched when appending to the query parameters. Fixes ampproject#2245

Merge pull request ampproject#2269 from avimehta/ga

eea7713

Assorted fixes to amp-analytics

Do not delete master frames on ads when there is no ad content to dis…

65127a8

…play.

Merge pull request ampproject#2542 from dvoytenko/viewerurl1

30fb196

Viewer URL override support for login flow

Merge pull request ampproject#2545 from sriramkrish85/cleanup

8550ddb

Do not delete master frames on ads when there is no ad content to display

i-mobile 3p amp-ad support

1b6dde2

Not supported on adsense

764efd5

powdercloud and others added 5 commits March 25, 2016 17:43

Slight cleanup of css-selectors.js.

5c785f5

Add missing super() calls.

015f3b7

This will be a compiler error soon.

Merge pull request ampproject#2711 from Gregable/validator

fd2fce8

Validator Roll-up

Make sure that holding on to unlisten handlers does not keep element/…

5568c07

…closures alive.

jridgewell assigned dvoytenko Mar 28, 2016

jridgewell and others added 4 commits March 28, 2016 12:44

Merge pull request ampproject#2717 from cramforce/iframe-done

dcdbc02

Make sure that holding on to unlisten handlers does not keep element/closures alive.

Merge pull request ampproject#2710 from erwinmombay/make-global-non-s…

ac030b7

…tringy make global config testing non string

Additional dependencies for amp-user-notifications and amp-analytics

d40acb9

Layout documentation corrections

619496d

dvoytenko and others added 14 commits March 28, 2016 11:10

Merge pull request ampproject#2726 from dvoytenko/fixes61

576516f

Additional dependencies for amp-user-notifications and amp-analytics

Used cached doc position in getLayoutRect.

9b7ee39

This showed up benchmarking real world docs.

amp-jwplayer extension

4acdd9f

Merge pull request ampproject#2709 from jwplayer/amp-jwplayer

68c5c0a

AMP jwplayer

Unselect text when marking document inactive

e12a1d1

Fixes ampproject#2730.

Merge pull request ampproject#2733 from jridgewell/clear-selection-on…

22f578f

…-inactive Unselect text when marking document inactive

Merge pull request ampproject#2727 from dvoytenko/fixes63

5d8e477

Layout documentation corrections

Fix minor grammar mistake

839246b

Change "it's URL" to "its URL" wherever it appears. No apostrophe should be used since this is not the possessive.

Merge pull request ampproject#2547 from cramforce/layout-rect

833693e

Used cached doc position in getLayoutRect.

Merge pull request ampproject#2735 from michaelmior/its-fix

bbbb7e6

Minor grammar mistake in documentation

request for integrating adman ad-server

49c4511

provide example for adman amp-ad & more

fix conflict with master

b0cfca2

request for integrating adman ad-server

b83d869

add files conflict

7b14d7f

anmarkom closed this Mar 29, 2016

anmarkom deleted the adman branch March 29, 2016 11:17

anmarkom mentioned this pull request Mar 29, 2016

request for integrating adman ad-server #2744

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

request for integrating adman ad-server #2 #2411

request for integrating adman ad-server #2 #2411

anmarkom commented Mar 3, 2016

googlebot commented Mar 3, 2016

anmarkom commented Mar 3, 2016

cramforce commented Mar 3, 2016

anmarkom commented Mar 4, 2016

anmarkom commented Mar 28, 2016

jridgewell commented Mar 28, 2016

dvoytenko commented Mar 28, 2016

request for integrating adman ad-server #2 #2411

request for integrating adman ad-server #2 #2411

Conversation

anmarkom commented Mar 3, 2016

googlebot commented Mar 3, 2016

anmarkom commented Mar 3, 2016

cramforce commented Mar 3, 2016

anmarkom commented Mar 4, 2016

anmarkom commented Mar 28, 2016

jridgewell commented Mar 28, 2016

dvoytenko commented Mar 28, 2016