Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support layout=container in amp-list #27159

Merged
merged 39 commits into from
Mar 20, 2020
Merged

Support layout=container in amp-list #27159

merged 39 commits into from
Mar 20, 2020

Commits on Mar 4, 2020

  1. Prototype for container layout in amp-list.

    @caroqliu
    William Chou authored and caroqliu committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    ea2f79c View commit details
    Browse the repository at this point in the history

  2. Remove unused import

    @caroqliu
    caroqliu committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    16fba4b View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2020

  1. Don't apply fillContent for layout=container

    @caroqliu
    caroqliu committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    402b7e0 View commit details
    Browse the repository at this point in the history

  2. Restore old example page

    @caroqliu
    caroqliu committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    98cf822 View commit details
    Browse the repository at this point in the history

  3. Move layout=container example to new document

    @caroqliu
    caroqliu committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    3e887d1 View commit details
    Browse the repository at this point in the history

  4. Move isLayoutSizeDefined_ to buildCallback

    @caroqliu
    caroqliu committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    fc21ff5 View commit details
    Browse the repository at this point in the history

  5. Add line

    @caroqliu
    caroqliu committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    cea0978 View commit details
    Browse the repository at this point in the history

  6. Set isLayoutSizeDefined when changing to container

    @caroqliu
    caroqliu committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    3ddfa58 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into amp-list-container

    @caroqliu
    caroqliu committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    565cdf2 View commit details
    Browse the repository at this point in the history

  8. Check layout is defined

    @caroqliu
    caroqliu committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    8f75c9d View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2020

  1. Replace isLayoutSizeDefined with isLayoutContainer

    @caroqliu
    caroqliu committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    52fc541 View commit details
    Browse the repository at this point in the history

  2. Fix some tests, comment out 4

    @caroqliu
    caroqliu committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    2fb5c8b View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2020

  1. Remove bottom padding for sample

    @caroqliu
    caroqliu committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    236f509 View commit details
    Browse the repository at this point in the history

  2. Move resize logic to attemptToFit

    @caroqliu
    caroqliu committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    041b6da View commit details
    Browse the repository at this point in the history

  3. Set styles on refresh

    @caroqliu
    caroqliu committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    e86c9b8 View commit details
    Browse the repository at this point in the history

  4. Uncomment tests

    @caroqliu
    caroqliu committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    898fe4e View commit details
    Browse the repository at this point in the history

  5. Restore line

    @caroqliu
    caroqliu committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    555adfc View commit details
    Browse the repository at this point in the history

  6. Will comments

    @caroqliu
    caroqliu committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    a45aede View commit details
    Browse the repository at this point in the history

  7. Handle changeToLayoutContainer action

    @caroqliu
    caroqliu committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    cd05420 View commit details
    Browse the repository at this point in the history

  8. Only set height for layout=container

    @caroqliu
    caroqliu committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    78651db View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2020

  1. Validate layout=container

    @caroqliu
    caroqliu committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    335d145 View commit details
    Browse the repository at this point in the history

  2. Assert placeholder presence for layout=container

    @caroqliu
    caroqliu committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    90d78ee View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2020

  1. Fix indent

    @caroqliu
    caroqliu committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    00e900e View commit details
    Browse the repository at this point in the history

  2. Move height locking to helper methods

    @caroqliu
    caroqliu committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    ec19be7 View commit details
    Browse the repository at this point in the history

  3. Unit test for unlock

    @caroqliu
    caroqliu committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    49c6adf View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into amp-list-container

    @caroqliu
    caroqliu committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    5a92d89 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2020

  1. Merge branch 'master' into amp-list-container

    @caroqliu
    caroqliu committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    aa98ede View commit details
    Browse the repository at this point in the history

  2. Unlock height inside render

    @caroqliu
    caroqliu committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    b4a80d3 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2020

  1. Merge branch 'master' into amp-list-container

    @caroqliu
    caroqliu committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    42b5a45 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2020

  1. Move measure to lockHeightAndMutate

    @caroqliu
    caroqliu committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    04168e5 View commit details
    Browse the repository at this point in the history

  2. Catch errors inside attemptToFit

    @caroqliu
    caroqliu committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    98d7b0f View commit details
    Browse the repository at this point in the history

  3. Remove arrow

    @caroqliu
    caroqliu committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    045bb57 View commit details
    Browse the repository at this point in the history

  4. Always measure height

    @caroqliu
    caroqliu committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    68e53f1 View commit details
    Browse the repository at this point in the history

  5. Will comments

    @caroqliu
    caroqliu committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    adc246f View commit details
    Browse the repository at this point in the history

  6. Add documentation

    @caroqliu
    caroqliu committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    8af262c View commit details
    Browse the repository at this point in the history

  7. Update md language

    @caroqliu
    caroqliu committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    48c2bc2 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2020

  1. Update info link 

    Co-Authored-By: Alan Orozco <alanorozco@users.noreply.github.com>
    @caroqliu @alanorozco
    caroqliu and alanorozco authored Mar 19, 2020
    Configuration menu
    Copy the full SHA
    206e863 View commit details
    Browse the repository at this point in the history

  2. Re-shrink boilerplate code 

    Co-Authored-By: Alan Orozco <alanorozco@users.noreply.github.com>
    @caroqliu @alanorozco
    caroqliu and alanorozco authored Mar 19, 2020
    Configuration menu
    Copy the full SHA
    929f72f View commit details
    Browse the repository at this point in the history

  3. Rename unlockHeight

    @caroqliu
    caroqliu committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    451b7ae View commit details
    Browse the repository at this point in the history