Support layout=container in amp-list #27159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caroqliu
force-pushed
the
amp-list-container
branch
from
ba53966
to
cea0978
Compare
|
Is this ready for review? |
|
@choumx Yes go ahead. :) Thanks! |
|
Hey @ampproject/wg-caching, these files were changed: |
extensions/amp-list/amp-list.md
Outdated
| [filter formats="websites, stories"] | ||
| In several cases, we may need the `<amp-list>` to resize on user interaction. For example, when the `<amp-list>` contains an amp-accordion that a user may tap on, when the contents of the `<amp-list>` change size due to bound CSS classes, or when the number of items inside an `<amp-list>` changes due to a bound `[src]` attribute. The `changeToLayoutContainer` action handles this by changing the amp list to `layout="CONTAINER"` when triggering this action. See the following example: | ||
| Before support for `layout="CONTAINER"` was added, in several cases, we needed the `<amp-list>` to resize on user interaction. For example, when the `<amp-list>` contains an amp-accordion that a user may tap on, when the contents of the `<amp-list>` change size due to bound CSS classes, or when the number of items inside an `<amp-list>` changes due to a bound `[src]` attribute. The `changeToLayoutContainer` action handles this by changing the amp list to `layout="CONTAINER"` when triggering this action. See the following example: |
There was a problem hiding this comment.
I think API documentation probably always reflect the latest state; describing new features usually is done in a blog or release notes.
It may be more useful to explain when to use layout=container and when to use changeToLayoutContainer action here.
There was a problem hiding this comment.
Heh, this is tricky to explain. Let's get this in and iterate.
We can also revisit in V2. changeToLayoutContainer and [is-layout-container] probably should be changed.
Gregable
approved these changes
Mar 19, 2020
alanorozco
approved these changes
Mar 19, 2020
extensions/amp-list/0.1/amp-list.js
Outdated
| * Applicable for layout=container. | ||
| * @private | ||
| */ | ||
| unlockHeight_() { |
There was a problem hiding this comment.
Nit: somehow communicate that this should be done inside a mutate callback, I usually add a suffix.
Suggested change
| unlockHeight_() { | |
| unlockHeightInsideMutate_() { |
Co-Authored-By: Alan Orozco <alanorozco@users.noreply.github.com>
Co-Authored-By: Alan Orozco <alanorozco@users.noreply.github.com>
twintwox
pushed a commit
to twintwox/amphtml
that referenced
this pull request
Mar 24, 2020
* Prototype for container layout in amp-list. * Remove unused import * Don't apply fillContent for layout=container * Restore old example page * Move layout=container example to new document * Move isLayoutSizeDefined_ to buildCallback * Add line * Set isLayoutSizeDefined when changing to container * Check layout is defined * Replace isLayoutSizeDefined with isLayoutContainer * Fix some tests, comment out 4 * Remove bottom padding for sample * Move resize logic to attemptToFit * Set styles on refresh * Uncomment tests * Restore line * Will comments * Handle changeToLayoutContainer action * Only set height for layout=container * Validate layout=container * Assert placeholder presence for layout=container * Fix indent * Move height locking to helper methods * Unit test for unlock * Unlock height inside render * Move measure to `lockHeightAndMutate` * Catch errors inside attemptToFit * Remove arrow * Always measure height * Will comments * Add documentation * Update md language * Update info link Co-Authored-By: Alan Orozco <alanorozco@users.noreply.github.com> * Re-shrink boilerplate code Co-Authored-By: Alan Orozco <alanorozco@users.noreply.github.com> * Rename unlockHeight Co-authored-by: William Chou <willchou@google.com> Co-authored-by: Alan Orozco <alanorozco@users.noreply.github.com>
honeybadgerdontcare
added a commit
to honeybadgerdontcare/amphtml
that referenced
this pull request
Mar 25, 2020
Closed
honeybadgerdontcare
added a commit
to honeybadgerdontcare/amphtml
that referenced
this pull request
Mar 25, 2020
Merged
honeybadgerdontcare
added a commit
that referenced
this pull request
Mar 25, 2020
* cl/302030563 Revision bump for #27280 * cl/302033641 Remove trailing whitespace from protoascii * cl/302035592 Revision bump for #27159 * cl/302061262 github commit msg missing or malformed * revert * revert * revert * revert * revert * trying to kickstart travis Co-authored-by: Greg Grothaus <greggrothaus@google.com>
erwinmombay
added a commit
that referenced
this pull request
Apr 3, 2020
This reverts commit b0187b7.
caroqliu
added a commit
to caroqliu/amphtml
that referenced
this pull request
Apr 14, 2020
This reverts commit b0187b7.
danielrozenberg
pushed a commit
that referenced
this pull request
Apr 14, 2020
danielrozenberg
pushed a commit
that referenced
this pull request
Apr 14, 2020
danielrozenberg
pushed a commit
that referenced
this pull request
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds off #26888, Closes #26873
PR deploy bot demo