🐛Change validator to let amp-access and amp-subscriptions coexist

[kushal]

Although the valdiator error is useful for pushing users to avoid errors, in practice amp-access and amp-subscriptions appear to coexist fine. This change is needed to allow publishers using amp-subscriptions to also use amp-access-scroll to let Scroll customers avoid ads.

[amp-owners-bot]

Hey @ampproject/wg-caching, these files were changed:

extensions/amp-access/validator-amp-access.protoascii
extensions/amp-subscriptions/0.1/test/validator-amp-subscriptions-errors.out
extensions/amp-subscriptions/validator-amp-subscriptions.protoascii

[honeybadgerdontcare]

/cc @chenshay

[jpettitt]

LGTM from a wg-access-subscriptions standpoint - not ideal but after VC with @kushal I think this is the least worst solution to the conflict between amp-access-scroll and amp-subscriptions.

@honeybadgerdontcare not sure what the validator test fail is, the error message is not very enlightening, can you give any pointers on how to fix?

[honeybadgerdontcare]

I'll look at this more closely later but this is the test that is failing. Essentially it's trying to ensure satisfies and requires matches up. https://github.com/ampproject/amphtml/blob/master/validator/engine/validator_test.js#L1662

[kushal]

I'll look at this more closely later but this is the test that is failing. Essentially it's trying to ensure satisfies and requires matches up. https://github.com/ampproject/amphtml/blob/master/validator/engine/validator_test.js#L1662

Thanks! I tried removing the relevant satisfies and requires but it still appears to fail.