Use unique iframe names based on unique domain #2955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Browsers are weird. If an iframe has a `name` attribute, it’s window will be cached. When you click a link, then go back, it will insert the **same** src window into the iframe regardless of a different `src`. Well, that hurts us since we generate a unique domain to load 3p frames. We’ll continue to use an old domain’s window, even though the src points to a new domain. Worse, when we post messages to the 3p frame, we will send it with an origin parsed from the `src` attribute even though that is not the real URL of the frame’s window. Fixes ampproject#2943
|
Thanks! Please add a test. |
|
Added. |
| resetServiceForTesting(window, 'bootstrapBaseUrl'); | ||
| resetCountForTesting(); | ||
| const newName = getIframe(window, div).name; | ||
| expect(newName).not.to.equal(name); |
There was a problem hiding this comment.
It'd be really good to hard code the actual name string in a test.
jridgewell
force-pushed
the
3p-frame-postMessage-unique-domain
branch
2 times, most recently
from
677468e
to
da80c87
Compare
| @@ -238,4 +245,33 @@ describe('3p-frame', () => { | |||
| }; | |||
| expect(getSubDomain(fakeWin)).to.equal('d-5670'); | |||
| }); | |||
|
|
|||
| it.only('uses a unique name based on domain', () => { | |||
|
LGTM |
jridgewell
force-pushed
the
3p-frame-postMessage-unique-domain
branch
from
da80c87
to
29a9b3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browsers are weird. If an iframe has a
nameattribute, it’s windowwill be cached. When you click a link, then go back, it will insert the
same src window into the iframe regardless of a different
src.Well, that hurts us since we generate a unique domain to load 3p
frames. We’ll continue to use an old domain’s window, even though the
src points to a new domain. Worse, when we post messages to the 3p
frame, we will send it with an origin parsed from the
srcattributeeven though that is not the real URL of the frame’s window.
Fixes #2943.