Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unique iframe names based on unique domain #2955

Merged

Commits on Apr 20, 2016

  1. Use unique iframe names based on unique domain

    Browsers are weird. If an iframe has a `name` attribute, it’s window
    will be cached. When you click a link, then go back, it will insert the
    **same** src window into the iframe regardless of a different `src`.
    
    Well, that hurts us since we generate a unique domain to load 3p
    frames. We’ll continue to use an old domain’s window, even though the
    src points to a new domain. Worse, when we post messages to the 3p
    frame, we will send it with an origin parsed from the `src` attribute
    even though that is not the real URL of the frame’s window.
    
    Fixes ampproject#2943
    jridgewell committed Apr 20, 2016
    Configuration menu
    Copy the full SHA
    fba82b6 View commit details
    Browse the repository at this point in the history
  2. Misc updates

    jridgewell committed Apr 20, 2016
    Configuration menu
    Copy the full SHA
    92b58f9 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2016

  1. Tests

    jridgewell committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    29a9b3d View commit details
    Browse the repository at this point in the history