✨Added validation for interactives #29748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gregable
approved these changes
Aug 7, 2020
extensions/amp-story-interactive/1.0/test/validator-amp-story-interactive-quiz.html
Outdated
Show resolved
Hide resolved
|
Hey @gmajoulet! These files were changed: Hey @newmuis, @Enriqe! These files were changed: |
mszylkowski
changed the title
gmajoulet
approved these changes
Aug 11, 2020
extensions/amp-story-interactive/validator-amp-story-interactive.protoascii
Outdated
Show resolved
Hide resolved
twifkak
added a commit
to twifkak/amphtml
that referenced
this pull request
Aug 13, 2020
Merged
twifkak
added a commit
that referenced
this pull request
Aug 13, 2020
* cl/324926702 Add value_regex support for css declarations. * cl/325128764 Fix css "bug" where declaration::FirstIdent doesn't return numerical identifiers. * cl/325141241 Fix AMP4Email CSS spec by ensuring only properties that should be allowed in emails are allowlisted. * cl/325253809 Improve `!important` CSS marker error message * cl/325256844 Revision bump for #29643 * cl/325359140 Validator: Add support for link imagesrcset and imagesizes * cl/325491434 Replace INVALID_DOCTYPE_HTML with a new message. * cl/325899515 Ban max-entries for AMP for Email * cl/326083373 Revert removal of requires_usage and deprecated_allow_duplicates for email * cl/326527018 Revision bump for #29766 * cl/326533269 Revision bump for #29748 Co-authored-by: Greg Grothaus <greggrothaus@google.com> Co-authored-by: honeybadgerdontcare <sedano@google.com> Co-authored-by: Justin Ridgewell <jridgewell@google.com>
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
* Added beginning of validation * Added most functionality to validator * Added text to results category * Created more validation tsets * Updated years * Fixed numbers in valdator example * Updated validator out * Added chip style transparent and grid-layer * Grid layer as ancestor
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
* cl/324926702 Add value_regex support for css declarations. * cl/325128764 Fix css "bug" where declaration::FirstIdent doesn't return numerical identifiers. * cl/325141241 Fix AMP4Email CSS spec by ensuring only properties that should be allowed in emails are allowlisted. * cl/325253809 Improve `!important` CSS marker error message * cl/325256844 Revision bump for ampproject#29643 * cl/325359140 Validator: Add support for link imagesrcset and imagesizes * cl/325491434 Replace INVALID_DOCTYPE_HTML with a new message. * cl/325899515 Ban max-entries for AMP for Email * cl/326083373 Revert removal of requires_usage and deprecated_allow_duplicates for email * cl/326527018 Revision bump for ampproject#29766 * cl/326533269 Revision bump for ampproject#29748 Co-authored-by: Greg Grothaus <greggrothaus@google.com> Co-authored-by: honeybadgerdontcare <sedano@google.com> Co-authored-by: Justin Ridgewell <jridgewell@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added validation rules for interactive components on stories
Closes #29465