Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator rollup #29830

Merged
merged 11 commits into from
Aug 13, 2020
Merged

Validator rollup #29830

merged 11 commits into from
Aug 13, 2020

Conversation

twifkak
Copy link
Member

@twifkak twifkak commented Aug 13, 2020

  • cl/326533269 Revision bump for ✨Added validation for interactives #29748
  • cl/326527018 Revision bump for Scale fade animation preset. #29766
  • cl/326083373 Revert removal of requires_usage and deprecated_allow_duplicates for email
  • cl/325899515 Ban max-entries for AMP for Email
  • cl/325491434 Replace INVALID_DOCTYPE_HTML with a new message.
  • cl/325359140 Validator: Add support for link imagesrcset and imagesizes
  • cl/325256844 Revision bump for Adds entity metadata support. #29643
  • cl/325253809 Improve !important CSS marker error message
  • cl/325141241 Fix AMP4Email CSS spec by ensuring only properties that should be allowed in emails are allowlisted.
  • cl/325128764 Fix css "bug" where declaration::FirstIdent doesn't return numerical identifiers.
  • cl/324926702 Add value_regex support for css declarations.

Greg Grothaus and others added 11 commits August 13, 2020 15:38
@twifkak
cl/324926702 Add value_regex support for css declarations.
daf0dbe
@twifkak
cl/325128764 Fix css "bug" where declaration::FirstIdent doesn't retu…
301a16d 
…rn numerical identifiers.
@twifkak
cl/325141241 Fix AMP4Email CSS spec by ensuring only properties that …
8f7baff 
…should be allowed in emails are allowlisted.
@honeybadgerdontcare @twifkak
cl/325253809 Improve !important CSS marker error message
9373ab6
@twifkak
cl/325256844 Revision bump for ampproject#29643
d5c0be3
@jridgewell @twifkak
cl/325359140 Validator: Add support for link imagesrcset and imagesizes
5a31c8b
@twifkak
cl/325491434 Replace INVALID_DOCTYPE_HTML with a new message.
6618993
@twifkak
cl/325899515 Ban max-entries for AMP for Email
1d17634
@twifkak
cl/326083373 Revert removal of requires_usage and deprecated_allow_du…
891501c 
…plicates for email
@twifkak
cl/326527018 Revision bump for ampproject#29766
d721c41
@twifkak
cl/326533269 Revision bump for ampproject#29748
ab8bd6c
@twifkak twifkak requested a review from banaag August 13, 2020 23:01
@amp-owners-bot
Copy link

amp-owners-bot bot commented Aug 13, 2020 •
edited by ampprojectbot
Loading

Hey @ampproject/wg-caching! These files were changed:

validator/js/engine/parse-css.js
validator/js/engine/validator.js
validator/testdata/amp4ads_feature_tests/doctype.out
validator/testdata/amp4ads_feature_tests/doctype.out.cpponly
validator/testdata/amp4email_feature_tests/amp-autocomplete.html
validator/testdata/amp4email_feature_tests/amp-autocomplete.out
validator/testdata/amp4email_feature_tests/css_declarations.html
validator/testdata/amp4email_feature_tests/css_declarations.out
validator/testdata/amp4email_feature_tests/css_strict.html
validator/testdata/amp4email_feature_tests/css_strict.out
validator/testdata/amp4email_feature_tests/no_latest_extensions.out
validator/testdata/feature_tests/css_declarations.out
+9 more

@google-cla google-cla bot added the cla: yes label Aug 13, 2020
@twifkak twifkak mentioned this pull request Aug 13, 2020
Closed
@twifkak
Copy link
Member Author

twifkak commented Aug 13, 2020

I'll submit without waiting for the mac cross-browser test. I don't think it's relevant (filed #29833).

@twifkak twifkak merged commit 4d5e5d3 into ampproject:master Aug 13, 2020
@twifkak twifkak deleted the rollup branch August 13, 2020 23:36
@twifkak twifkak mentioned this pull request Sep 16, 2020
Closed
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
@twifkak @honeybadgerdontcare
@jridgewell @ed-bird
Validator rollup (ampproject#29830)
4663f6b 
* cl/324926702 Add value_regex support for css declarations.

* cl/325128764 Fix css "bug" where declaration::FirstIdent doesn't return numerical identifiers.

* cl/325141241 Fix AMP4Email CSS spec by ensuring only properties that should be allowed in emails are allowlisted.

* cl/325253809 Improve `!important` CSS marker error message

* cl/325256844 Revision bump for ampproject#29643

* cl/325359140 Validator: Add support for link imagesrcset and imagesizes

* cl/325491434 Replace INVALID_DOCTYPE_HTML with a new message.

* cl/325899515 Ban max-entries for AMP for Email

* cl/326083373 Revert removal of requires_usage and deprecated_allow_duplicates for email

* cl/326527018 Revision bump for ampproject#29766

* cl/326533269 Revision bump for ampproject#29748

Co-authored-by: Greg Grothaus <greggrothaus@google.com>
Co-authored-by: honeybadgerdontcare <sedano@google.com>
Co-authored-by: Justin Ridgewell <jridgewell@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banaag banaag banaag approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental WG: caching
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@twifkak @banaag @ampprojectbot @honeybadgerdontcare @jridgewell