🐛 Fix value_regex for decimal option-*-results-threshold attr values #31241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gmajoulet, @mszylkowski, @ampproject/wg-caching! These files were changed: |
|
cc @ampproject/wg-caching |
6 tasks
mszylkowski
approved these changes
Nov 18, 2020
Gregable
approved these changes
Nov 18, 2020
banaag
added a commit
to banaag/amphtml
that referenced
this pull request
Nov 24, 2020
Closed
amaltas
added a commit
that referenced
this pull request
Dec 4, 2020
* cl/343164010 Revision bump for #31241 * cl/343904483 Implements gated module/nomodule validation with test cases * cl/345313752 Revision bump for #31271 * Update validator-amp-accordion.protoascii * Add htmlparser-interface.js in allowlist * Fix invalid merge diff resolution Co-authored-by: Allan Banaag <banaag@google.com> Co-authored-by: honeybadgerdontcare <sedano@google.com>
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
* cl/343164010 Revision bump for ampproject#31241 * cl/343904483 Implements gated module/nomodule validation with test cases * cl/345313752 Revision bump for ampproject#31271 * Update validator-amp-accordion.protoascii * Add htmlparser-interface.js in allowlist * Fix invalid merge diff resolution Co-authored-by: Allan Banaag <banaag@google.com> Co-authored-by: honeybadgerdontcare <sedano@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While importing the validator spec into the AMP-WP plugin (ampproject/amp-wp#5608), I noticed a but with the regex for the
option-*-results-thresholdattributes on theamp-story-interactive-resultscomponent. Namely, if you provide a decimal value, ten it is flagged as a validation error:If I supply
80.instead of80.5then it passes. Clearly a capture group was intended rather than a character class.