-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator rollup #31316
Validator rollup #31316
Conversation
banaag
commented
Nov 24, 2020
- cl/343904483 Implements gated module/nomodule validation with test cases
- cl/343164010 Revision bump for 🐛 Fix value_regex for decimal option-*-results-threshold attr values #31241
Hey @ampproject/wg-caching! These files were changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pushing this important pr forward
@rsimha we are doing a validation check against
|
@rsimha I think I got it right in this commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving build-system/tasks/presubmit-checks.js
There was a problem with this PR as it's missing some code that should have been included. That code is in PR #31373. To keep things simple we're closing this and once that PR is merged will do another rollup. |