-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Fixit: Update some imports of assertions to use standalone helpers #32828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @Jiaming-X! These files were changed:
Hey @jeffkaufman! These files were changed:
Hey @alanorozco! These files were changed:
Hey @gmajoulet, @newmuis, @Enriqe! These files were changed:
|
rcebulko
force-pushed
the
assert-single-imports
branch
2 times, most recently
from
February 24, 2021 15:34
4c1e36d
to
c3a57f7
Compare
rcebulko
force-pushed
the
assert-single-imports
branch
2 times, most recently
from
March 1, 2021 19:45
6ce2e25
to
4caa9d6
Compare
rcebulko
requested review from
jridgewell
and removed request for
kristoferbaxter
March 1, 2021 23:10
rcebulko
force-pushed
the
assert-single-imports
branch
from
March 2, 2021 21:49
0ec0487
to
cdb52b1
Compare
jridgewell
approved these changes
Mar 2, 2021
erwinmombay
approved these changes
Mar 3, 2021
rsimha
approved these changes
Mar 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bundle-size bump.
This was referenced Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on #32788
Updates a subset of
devAssert
/userAssert
imports; splitting up migration into a few PRs to reduce conflicts, make some PRs simple find-replace refactors, and make identifying issues easier.Updates all
import {devAssert} from '...../log'
toimport {pureDevAssert as devAssert} from '......./assert'
(same foruserAssert
).