Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Fixit: Update some imports of assertions to use standalone helpers #32828

Merged
merged 16 commits into from
Mar 3, 2021

Conversation

rcebulko
Copy link
Contributor

Building on #32788

Updates a subset of devAssert/userAssert imports; splitting up migration into a few PRs to reduce conflicts, make some PRs simple find-replace refactors, and make identifying issues easier.

Updates all import {devAssert} from '...../log' to import {pureDevAssert as devAssert} from '......./assert' (same for userAssert).

@amp-owners-bot
Copy link

amp-owners-bot bot commented Feb 23, 2021

Hey @Jiaming-X! These files were changed:

extensions/amp-ad-network-adsense-impl/0.1/adsense-shared-state.js

Hey @jeffkaufman! These files were changed:

extensions/amp-ad-network-adsense-impl/0.1/adsense-shared-state.js
extensions/amp-ad-network-doubleclick-impl/0.1/test/test-doubleclick-sra.js

Hey @alanorozco! These files were changed:

extensions/amp-connatix-player/0.1/amp-connatix-player.js
extensions/amp-delight-player/0.1/amp-delight-player.js
extensions/amp-kaltura-player/0.1/amp-kaltura-player.js
extensions/amp-o2-player/0.1/amp-o2-player.js
extensions/amp-redbull-player/0.1/amp-redbull-player.js
extensions/amp-springboard-player/0.1/amp-springboard-player.js

Hey @gmajoulet, @newmuis, @Enriqe! These files were changed:

extensions/amp-story/1.0/animation-presets.js
extensions/amp-story/1.0/bookend/components/article.js
extensions/amp-story/1.0/bookend/components/cta-link.js
extensions/amp-story/1.0/bookend/components/heading.js
extensions/amp-story/1.0/bookend/components/landscape.js
extensions/amp-story/1.0/bookend/components/portrait.js
extensions/amp-story/1.0/bookend/components/text-box.js
extensions/amp-story/1.0/live-story-manager.js
extensions/amp-story/1.0/pagination-buttons.js
extensions/amp-story/1.0/simple-template.js

@rcebulko rcebulko force-pushed the assert-single-imports branch 2 times, most recently from 4c1e36d to c3a57f7 Compare February 24, 2021 15:34
@rcebulko rcebulko marked this pull request as draft February 25, 2021 16:34
@rcebulko rcebulko force-pushed the assert-single-imports branch 2 times, most recently from 6ce2e25 to 4caa9d6 Compare March 1, 2021 19:45
@rcebulko rcebulko requested review from jridgewell and removed request for kristoferbaxter March 1, 2021 23:10
@rcebulko rcebulko marked this pull request as ready for review March 2, 2021 16:20
@rcebulko rcebulko force-pushed the assert-single-imports branch from 0ec0487 to cdb52b1 Compare March 2, 2021 21:49
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bundle-size bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants