⏪ Revert import changes for assertions #33434
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically a revert of #32828
I was trying to update imports of assertions in waves. During my attempt at a second wave, I discovered a bunch of mostly untested functionality depending on the existing AMP assertion logic, suggesting the swap is not quite so clean. Undoing these changes, and will just make
src/log.js#assert
wrapsrc/core/assert.js#assertion
; new code/code insrc/{context,preact,core}
can use the dependency-free helper, and existing AMP code can me migrated manually (or not).