♻️ Extract error helpers and rethrowAsync into core #33881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcebulko
force-pushed
the
core-rethrow
branch
2 times, most recently
from
958f4c7
to
c14817c
Compare
|
Hey @jridgewell! These files were changed: |
jridgewell
approved these changes
Apr 16, 2021
This was
linked to
issues
May 12, 2021
This was referenced May 22, 2021
This was referenced Jun 7, 2021
This was referenced Jul 26, 2021
Open
rochapablo
pushed a commit
to rochapablo/amphtml
that referenced
this pull request
Aug 30, 2021
* Move error helpers from src/log to src/core/error * Remove src/contex/values from allowlist * Remove src/context/scheduler from allowlist * Update dep check config * Fix import (merge?) error in test file * Use String includes polyfill * Extract error tests to test/unit/core * Update imports of dupeErrorIfNecessary * Update imports of rethrowAsync * Remove unused imports
This was referenced Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jridgewell Look at this f19ff64...5c8eda0 not the files changed list