Updates to colanalytics vendor config for amp-analytics. #3849

avimehta · 2016-06-30T19:22:06Z

Per request from @ColombiaAnalytics in #3828

ColombiaAnalytics · 2016-07-01T04:22:56Z

Hi,

It perfectly fine. Thanks, once again.

ColombiaAnalytics · 2016-07-01T15:15:22Z

Thanks Bro.

Thanks & Regards,

Mukul Tanwar
9717359710

From: Avi Mehta notifications@github.com
Sent: Friday, July 1, 2016 8:23:15 PM
To: ampproject/amphtml
Cc: Mukul Tanwar; Mention
Subject: Re: [ampproject/amphtml] Updates to colanalytics vendor config for amp-analytics. (#3849)

Merged #3849 #3849.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/3849#event-710592780, or mute the threadhttps://github.com/notifications/unsubscribe/ARWRN3qUBa2DmMQ8EyR3kpMpxwbthI4mks5qRSnbgaJpZM4JCgY8.

The hunt is on for young creative and media minds under 30 years. Brand Equity Young Spikes 2016 competition. Winners get a free trip to Singapore to compete at Spikes Asia 2016. www.etbrandequity.com/youngspikes

ColombiaAnalytics · 2016-07-04T09:50:49Z

Hi Avi,

I was unable to find t changes in "https://cdn.ampproject.org/v0/amp-analytics-0.1.js".

Will the changes be visible after some time.

Thanks & Regards,

Mukul Tanwar
9717359710

From: Mukul Tanwar
Sent: Friday, July 1, 2016 8:45:08 PM
To: ampproject/amphtml; ampproject/amphtml
Cc: Mention
Subject: Re: [ampproject/amphtml] Updates to colanalytics vendor config for amp-analytics. (#3849)

Thanks Bro.

Thanks & Regards,

Mukul Tanwar
9717359710

From: Avi Mehta notifications@github.com
Sent: Friday, July 1, 2016 8:23:15 PM
To: ampproject/amphtml
Cc: Mukul Tanwar; Mention
Subject: Re: [ampproject/amphtml] Updates to colanalytics vendor config for amp-analytics. (#3849)

Merged #3849 #3849.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/3849#event-710592780, or mute the threadhttps://github.com/notifications/unsubscribe/ARWRN3qUBa2DmMQ8EyR3kpMpxwbthI4mks5qRSnbgaJpZM4JCgY8.

The hunt is on for young creative and media minds under 30 years. Brand Equity Young Spikes 2016 competition. Winners get a free trip to Singapore to compete at Spikes Asia 2016. www.etbrandequity.com/youngspikes

* master: (236 commits) trim all the columns (ampproject#3894) Refactoring: Turn private custom element methods into functions. (ampproject#3882) Lower the load priority of ad shaped iframes. (ampproject#3863) JsDoc fix (ampproject#3892) Add screenshots for Opera to AMP Validator extension. (ampproject#3866) Fix renaming of generated JSCompiler_prototypeAlias variable. (ampproject#3887) fix typo in amp-sidebar.md (ampproject#3833) Validator Roll-up (ampproject#3885) [CryptoService] Leverage browser native Crypto API to hash strings. (ampproject#3850) Size update (ampproject#3883) copy amp-ad docs to builtins (ampproject#3879) move doc to extension (ampproject#3878) [amp-experiment] Exposes isDismissed() method in AmpUserNotification (ampproject#3832) fix action-impl warning on dist (ampproject#3867) Add params for microad (ampproject#3827) Fixed some A4A tests. (ampproject#3859) Updates to colanalytics vendor config for amp-analytics. (ampproject#3849) Changes to implement A4A (AMP ads for AMP pages) (ampproject#3534) Addresses comment left over from PR#3841 (ampproject#3853) Expose submit event with on=submit:el.action syntax. (ampproject#3739) ...

ColombiaAnalytics · 2016-07-11T13:09:15Z

Hi Avi,

I couldn't find changes in "https://cdn.ampproject.org/v0/amp-analytics-0.1.js". Have the Merge been completed.

Thanks & Regards,

Mukul Tanwar
9717359710

From: Mukul Tanwar
Sent: Monday, July 4, 2016 3:20:33 PM
To: ampproject/amphtml; ampproject/amphtml
Cc: Mention
Subject: Re: [ampproject/amphtml] Updates to colanalytics vendor config for amp-analytics. (#3849)

Hi Avi,

I was unable to find t changes in "https://cdn.ampproject.org/v0/amp-analytics-0.1.js".

Will the changes be visible after some time.

Thanks & Regards,

Mukul Tanwar
9717359710

From: Mukul Tanwar
Sent: Friday, July 1, 2016 8:45:08 PM
To: ampproject/amphtml; ampproject/amphtml
Cc: Mention
Subject: Re: [ampproject/amphtml] Updates to colanalytics vendor config for amp-analytics. (#3849)

Thanks Bro.

Thanks & Regards,

Mukul Tanwar
9717359710

From: Avi Mehta notifications@github.com
Sent: Friday, July 1, 2016 8:23:15 PM
To: ampproject/amphtml
Cc: Mukul Tanwar; Mention
Subject: Re: [ampproject/amphtml] Updates to colanalytics vendor config for amp-analytics. (#3849)

Merged #3849 #3849.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/3849#event-710592780, or mute the threadhttps://github.com/notifications/unsubscribe/ARWRN3qUBa2DmMQ8EyR3kpMpxwbthI4mks5qRSnbgaJpZM4JCgY8.

avimehta · 2016-07-14T19:29:22Z

This seems to be live now. Can you confirm?

Release can take somewhere between 7-13 days for changes to go live. If something is wrong with a build, the delay can be longer.

ColombiaAnalytics · 2016-08-11T12:07:23Z

Hi Avi,

Had a query. We observed hits from amp pages, have canonical path incomplete. The domain name is missing from canonical path. Need to know is this the actual canonical path coming from amp pages. As earlier we observed the canonical path coming to be complete. Example

http://timesofindia/news/something/page.cms

But at present we are getting

/news/something/page.cms

The domain name is missing in the canonical path. Please let me know is this the actual behavior for all amp pages.

Thanks & Regards,

Mukul Tanwar
9717359710

From: Avi Mehta notifications@github.com
Sent: Friday, July 1, 2016 12:52:25 AM
To: ampproject/amphtml
Cc: Mukul Tanwar; Mention
Subject: [ampproject/amphtml] Updates to colanalytics vendor config for amp-analytics. (#3849)

Per request from @ColombiaAnalyticshttps://github.com/ColombiaAnalytics in #3828 #3828

You can view, comment on, or merge this pull request online at:

#3849

Commit Summary

Updates to colanalytics vendor config for amp-analytics.

File Changes

M extensions/amp-analytics/0.1/test/vendor-requests.jsonhttps://github.com/Updates to colanalytics vendor config for amp-analytics. #3849/files#diff-0 (2)
M extensions/amp-analytics/0.1/vendors.jshttps://github.com/Updates to colanalytics vendor config for amp-analytics. #3849/files#diff-1 (4)

Patch Links:

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/3849, or mute the threadhttps://github.com/notifications/unsubscribe/ARWRN5mYe3V65uArchVOIABdBFX01FQPks5qRBdxgaJpZM4JCgY8.

Donating your organs saves multiple lives and in a small but meaningful way, eases the pain of your family too. Pledge your organs on www.OrganDonationDay.in

avimehta · 2016-08-11T23:45:52Z

In a URL like http://timesofindia.com/news/something/page.cms, the CANONICAL_HOST is timesofindia.com. CANONICAL_PATH is /news/something/page.cms and CANONICAL_URL is http://timesofindia.com/news/something/page.cms. https://github.com/ampproject/amphtml/blob/master/extensions/amp-analytics/analytics-vars.md#page-and-content explains this.

So what you are seeing is expected. If you want the full URL, your vendor config needs to be changed.

ColombiaAnalytics · 2016-09-26T11:18:28Z

Hi Bro.

We need to bring CANONICAL_URL in that case. Please help me in this. Need your help.

Thanks & Regards,

Mukul Tanwar
9717359710

From: Avi Mehta notifications@github.com
Sent: Friday, August 12, 2016 5:16:11 AM
To: ampproject/amphtml
Cc: Mukul Tanwar; Mention
Subject: Re: [ampproject/amphtml] Updates to colanalytics vendor config for amp-analytics. (#3849)

In a URL like http://timesofindia.com/news/something/page.cms, the CANONICAL_HOST is timesofindia.com. CANONICAL_PATH is /news/something/page.cms and CANONICAL_URL is http://timesofindia.com/news/something/page.cms. https://github.com/ampproject/amphtml/blob/master/extensions/amp-analytics/analytics-vars.md#page-and-content explains this.

So what you are seeing is expected. If you want the full URL, your vendor config needs to be changed.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/3849#issuecomment-239326560, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ARWRN6xcV1LWlgf9c_4uYwUGBQuKeC-tks5qe7RDgaJpZM4JCgY8.

ColombiaAnalytics · 2016-09-28T09:33:19Z

Hi Avi,

We need to bring CANONICAL_URL in that case. Please help me in this. Need your help.

Thanks & Regards,

Mukul Tanwar
9717359710

Thanks & Regards,

Mukul Tanwar
9717359710

From: Mukul Tanwar
Sent: Monday, September 26, 2016 4:48 PM
To: ampproject/amphtml; ampproject/amphtml
Cc: Mention
Subject: Re: [ampproject/amphtml] Updates to colanalytics vendor config for amp-analytics. (#3849)

Hi Bro.

We need to bring CANONICAL_URL in that case. Please help me in this. Need your help.

Thanks & Regards,

Mukul Tanwar
9717359710

From: Avi Mehta notifications@github.com
Sent: Friday, August 12, 2016 5:16:11 AM
To: ampproject/amphtml
Cc: Mukul Tanwar; Mention
Subject: Re: [ampproject/amphtml] Updates to colanalytics vendor config for amp-analytics. (#3849)

In a URL like http://timesofindia.com/news/something/page.cms, the CANONICAL_HOST is timesofindia.com. CANONICAL_PATH is /news/something/page.cms and CANONICAL_URL is http://timesofindia.com/news/something/page.cms. https://github.com/ampproject/amphtml/blob/master/extensions/amp-analytics/analytics-vars.md#page-and-content explains this.

So what you are seeing is expected. If you want the full URL, your vendor config needs to be changed.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/3849#issuecomment-239326560, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ARWRN6xcV1LWlgf9c_4uYwUGBQuKeC-tks5qe7RDgaJpZM4JCgY8.

rudygalfi · 2016-09-28T16:43:20Z

@ColombiaAnalytics Can you please submit a new pull request that updates your vendor configuration?

Updates to colanalytics vendor config for amp-analytics.

77d6729

avimehta added the WG: analytics label Jun 30, 2016

avimehta self-assigned this Jun 30, 2016

avimehta mentioned this pull request Jun 30, 2016

Added bhType and all site traffic #3828

Closed

avimehta merged commit 610b01e into ampproject:master Jul 1, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates to colanalytics vendor config for amp-analytics. #3849

Updates to colanalytics vendor config for amp-analytics. #3849

avimehta commented Jun 30, 2016

ColombiaAnalytics commented Jul 1, 2016

ColombiaAnalytics commented Jul 1, 2016

ColombiaAnalytics commented Jul 4, 2016

ColombiaAnalytics commented Jul 11, 2016

avimehta commented Jul 14, 2016

ColombiaAnalytics commented Aug 11, 2016

avimehta commented Aug 11, 2016

ColombiaAnalytics commented Sep 26, 2016

ColombiaAnalytics commented Sep 28, 2016

rudygalfi commented Sep 28, 2016

Updates to colanalytics vendor config for amp-analytics. #3849

Updates to colanalytics vendor config for amp-analytics. #3849

Conversation

avimehta commented Jun 30, 2016

ColombiaAnalytics commented Jul 1, 2016

ColombiaAnalytics commented Jul 1, 2016

ColombiaAnalytics commented Jul 4, 2016

ColombiaAnalytics commented Jul 11, 2016

avimehta commented Jul 14, 2016

ColombiaAnalytics commented Aug 11, 2016

avimehta commented Aug 11, 2016

ColombiaAnalytics commented Sep 26, 2016

ColombiaAnalytics commented Sep 28, 2016

rudygalfi commented Sep 28, 2016