Lower the load priority of ad shaped iframes. #3863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramforce
force-pushed
the
iframe-priority
branch
from
96e8acb
to
70ac549
Compare
| @@ -436,6 +444,35 @@ function makeIOsScrollable(element) { | |||
| return element; | |||
| } | |||
|
|
|||
| // Most common ad sizes | |||
| const adSizes = [[300, 250], [320, 50], [300, 50], [320, 100]]; | |||
There was a problem hiding this comment.
A comment about which is width, which is height?
|
I don't know about the typical shape of ads. Otherwise LGTM |
Some sites use `amp-iframe` to load ads. This is not OK in AMP. With this change at least they render with the same priority as ads.
cramforce
force-pushed
the
iframe-priority
branch
from
70ac549
to
9518d98
Compare
|
LGTM |
|
I asked @jasti about the ad sizes :) |
|
Oh yeah, so numb to saying these dimensions all the time. Always width x height. |
jonasmattsson1
added a commit
to widespace-os/amphtml
that referenced
this pull request
Jul 5, 2016
* master: (236 commits) trim all the columns (ampproject#3894) Refactoring: Turn private custom element methods into functions. (ampproject#3882) Lower the load priority of ad shaped iframes. (ampproject#3863) JsDoc fix (ampproject#3892) Add screenshots for Opera to AMP Validator extension. (ampproject#3866) Fix renaming of generated JSCompiler_prototypeAlias variable. (ampproject#3887) fix typo in amp-sidebar.md (ampproject#3833) Validator Roll-up (ampproject#3885) [CryptoService] Leverage browser native Crypto API to hash strings. (ampproject#3850) Size update (ampproject#3883) copy amp-ad docs to builtins (ampproject#3879) move doc to extension (ampproject#3878) [amp-experiment] Exposes isDismissed() method in AmpUserNotification (ampproject#3832) fix action-impl warning on dist (ampproject#3867) Add params for microad (ampproject#3827) Fixed some A4A tests. (ampproject#3859) Updates to colanalytics vendor config for amp-analytics. (ampproject#3849) Changes to implement A4A (AMP ads for AMP pages) (ampproject#3534) Addresses comment left over from PR#3841 (ampproject#3853) Expose submit event with on=submit:el.action syntax. (ampproject#3739) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some sites use
amp-iframeto load ads. This is not OK in AMP. With this change at least they render with the same priority as ads.