Skip to content

Commit

Permalink
Backport 248 to 2.x (opensearch-project#291)
Browse files Browse the repository at this point in the history
* [Bug Bash Fixes][Event Analytics] some fixes (opensearch-project#248)

* markdown doesnt care if there's data

Signed-off-by: Eric Wei <menwe@amazon.com>

* empty query issue

Signed-off-by: Eric Wei <menwe@amazon.com>

* remove duplicate styles

Signed-off-by: Eric Wei <menwe@amazon.com>

* hide config panel for markdown

Signed-off-by: Eric Wei <menwe@amazon.com>

* fix panel infinite calls

Signed-off-by: Eric Wei <menwe@amazon.com>

* hide availability for event analytics

Signed-off-by: Eric Wei <menwe@amazon.com>

* remove error message from search

Signed-off-by: Eric Wei <menwe@amazon.com>

* fix tab issue with linting fix

Signed-off-by: Eric Wei <menwe@amazon.com>

* remove side group button

Signed-off-by: Eric Wei <menwe@amazon.com>

* lift data validation to vis container for linting issue

Signed-off-by: Eric Wei <menwe@amazon.com>

* update snapshots and minor changes

Signed-off-by: Eric Wei <menwe@amazon.com>

---------

Signed-off-by: Eric Wei <menwe@amazon.com>
(cherry picked from commit df92519)

* updated snapshots

Signed-off-by: Eric Wei <menwe@amazon.com>

* fix incorrect conflicts resolving

Signed-off-by: Eric Wei <menwe@amazon.com>

---------

Signed-off-by: Eric Wei <menwe@amazon.com>
(cherry picked from commit bfa3692)
  • Loading branch information
mengweieric authored and vamsi-amazon committed Mar 22, 2023
1 parent be8f9a3 commit ac500eb
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions public/components/visualizations/visualization.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ export const Visualization = ({

if (isEmpty(series)) return [false, VISUALIZATION_ERROR.INVALID_DATA]; // series is required to any visualization type

// timeseries
if (vis.id === VIS_CHART_TYPES.Line && (isEmpty(span) || dimensions.length > 0))
return [false, VISUALIZATION_ERROR.INVALID_DATA];

// bars, pie
if (dimensions.length < 1 && isEmpty(span)) return [false, VISUALIZATION_ERROR.INVALID_DATA];

Expand Down

0 comments on commit ac500eb

Please sign in to comment.