Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 248 to 2.x #291

Merged
merged 3 commits into from
Feb 21, 2023

Conversation

mengweieric
Copy link
Collaborator

@mengweieric mengweieric commented Feb 21, 2023

Description

Backport #248 to 2.x.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* markdown doesnt care if there's data

Signed-off-by: Eric Wei <menwe@amazon.com>

* empty query issue

Signed-off-by: Eric Wei <menwe@amazon.com>

* remove duplicate styles

Signed-off-by: Eric Wei <menwe@amazon.com>

* hide config panel for markdown

Signed-off-by: Eric Wei <menwe@amazon.com>

* fix panel infinite calls

Signed-off-by: Eric Wei <menwe@amazon.com>

* hide availability for event analytics

Signed-off-by: Eric Wei <menwe@amazon.com>

* remove error message from search

Signed-off-by: Eric Wei <menwe@amazon.com>

* fix tab issue with linting fix

Signed-off-by: Eric Wei <menwe@amazon.com>

* remove side group button

Signed-off-by: Eric Wei <menwe@amazon.com>

* lift data validation to vis container for linting issue

Signed-off-by: Eric Wei <menwe@amazon.com>

* update snapshots and minor changes

Signed-off-by: Eric Wei <menwe@amazon.com>

---------

Signed-off-by: Eric Wei <menwe@amazon.com>
(cherry picked from commit df92519)
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
@mengweieric mengweieric requested a review from a team as a code owner February 21, 2023 18:47
@mengweieric
Copy link
Collaborator Author

Build failure due to known issue opensearch-project/opensearch-build#3210

@mengweieric mengweieric merged commit bfa3692 into opensearch-project:2.x Feb 21, 2023
@mengweieric mengweieric deleted the backport-248-to-2.x branch February 21, 2023 21:55
pjfitzgibbons pushed a commit that referenced this pull request Mar 28, 2023
* [Bug Bash Fixes][Event Analytics] some fixes (#248)

* markdown doesnt care if there's data

Signed-off-by: Eric Wei <menwe@amazon.com>

* empty query issue

Signed-off-by: Eric Wei <menwe@amazon.com>

* remove duplicate styles

Signed-off-by: Eric Wei <menwe@amazon.com>

* hide config panel for markdown

Signed-off-by: Eric Wei <menwe@amazon.com>

* fix panel infinite calls

Signed-off-by: Eric Wei <menwe@amazon.com>

* hide availability for event analytics

Signed-off-by: Eric Wei <menwe@amazon.com>

* remove error message from search

Signed-off-by: Eric Wei <menwe@amazon.com>

* fix tab issue with linting fix

Signed-off-by: Eric Wei <menwe@amazon.com>

* remove side group button

Signed-off-by: Eric Wei <menwe@amazon.com>

* lift data validation to vis container for linting issue

Signed-off-by: Eric Wei <menwe@amazon.com>

* update snapshots and minor changes

Signed-off-by: Eric Wei <menwe@amazon.com>

---------

Signed-off-by: Eric Wei <menwe@amazon.com>
(cherry picked from commit df92519)

* updated snapshots

Signed-off-by: Eric Wei <menwe@amazon.com>

* fix incorrect conflicts resolving

Signed-off-by: Eric Wei <menwe@amazon.com>

---------

Signed-off-by: Eric Wei <menwe@amazon.com>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
* [Bug Bash Fixes][Event Analytics] some fixes (opensearch-project#248)

* markdown doesnt care if there's data

Signed-off-by: Eric Wei <menwe@amazon.com>

* empty query issue

Signed-off-by: Eric Wei <menwe@amazon.com>

* remove duplicate styles

Signed-off-by: Eric Wei <menwe@amazon.com>

* hide config panel for markdown

Signed-off-by: Eric Wei <menwe@amazon.com>

* fix panel infinite calls

Signed-off-by: Eric Wei <menwe@amazon.com>

* hide availability for event analytics

Signed-off-by: Eric Wei <menwe@amazon.com>

* remove error message from search

Signed-off-by: Eric Wei <menwe@amazon.com>

* fix tab issue with linting fix

Signed-off-by: Eric Wei <menwe@amazon.com>

* remove side group button

Signed-off-by: Eric Wei <menwe@amazon.com>

* lift data validation to vis container for linting issue

Signed-off-by: Eric Wei <menwe@amazon.com>

* update snapshots and minor changes

Signed-off-by: Eric Wei <menwe@amazon.com>

---------

Signed-off-by: Eric Wei <menwe@amazon.com>
(cherry picked from commit df92519)

* updated snapshots

Signed-off-by: Eric Wei <menwe@amazon.com>

* fix incorrect conflicts resolving

Signed-off-by: Eric Wei <menwe@amazon.com>

---------

Signed-off-by: Eric Wei <menwe@amazon.com>
(cherry picked from commit bfa3692)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants