-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yarn
version incompatibility issue blocks Dashboards plugins CI, docker-image, windows build
#3210
Comments
This issue is brought up late as plugins are not always following the core defined yarn version. After quick glance around 5 docker images and 1 ami get impacted.
Among these 6 there are 2 docker images related to bundle build + integTest, and 1 ami related to bundle build, means they need to be updated now to avoid failures on 2.6.0 builds. The rest of them can be updated at a later time. The updates of these images/ami should retrieve the version of yarn dynamically from core osd repo, instead of hardcoding again in the template. Thanks. |
Would it be easier to mitigate by downgrading the yarn version in openearch-js to be compatible with opensearch-dashboard? |
PRs:
|
Why don't we just revert opensearch-project/OpenSearch-Dashboards@de89c52 in In general, OpenSearch Dashboards considers bumping direct dependencies (such as |
+1 @joshuarrrr. I think the call if we want the sigv4 into OpenSearch Dashboards core, without a deep dive, I don't see why not cut a minor release OpenSearch JS client for 1.x to have this feature. And then have OpenSearch Dashboards take the minor version bump from the client. However, I will note that client does not appear to be following the branching strategy of the project while also not deprecating previous versions. If I'm just a regular NPM user, I would expect that OpenSearch JS 1.x is being supported even though it is not actually being supported. cc: @dblock @CEHENKLE @bbarani Granted I only checked one other repo's 1.x branches, it would appear that clients aren't actively supporting 1.x versions. Is this intentional and called out somewhere? |
Adding @zhongnansu @derek-ho on to the change on this. Thanks. |
@joshuarrrr
|
Might be a confusing matrix but on our site we state:
[SOURCE]
For build wise we usually rely on the build CI to verify and have reverted commits in the past. |
@kavilla @joshuarrrr |
Could we at least test if the yarn version bump would fix the build?
|
@peterzhuamazon |
@peterzhuamazon This PR is merged to Adding @AMoo-Miki, since I saw you opened a related issue in plugin repo about the yarn config in CI workflow. I do want to mention that the same way to configure yarn is used across almost all dashboards plugins in Opensearch Org. opensearch-project/dashboards-observability#290 |
Tagging @gaiksaya as she is the release manager for 2.6.0 release. |
Hi @zhongnansu @peterzhuamazon What are the next steps here? As the today is the code cutoff date for 2.6.0 trying to see if we need to extend that from dashboards prespective. |
All images updated now in docker hub (3131 3126 3125 3123 docker-build Jenkins). |
@peterzhuamazon I do not see any PRs for adding yarn version https://github.com/opensearch-project/opensearch-build/tree/main/docker/ci/dockerfiles/current am I missing anything? |
The next step is approve and merge in this PR: opensearch-project/OpenSearch-Dashboards#3465, to fix yarn issue and unblock plugin CI @gaiksaya |
All the effected plugins were using a flawed logic to install Node.js and Yarn runtimes based on the information they were reading from OSD's manifest. They all took the ranges OSD provided, manipulated it incorrectly and attempted to install Node and Yarn. I have gone through all the repos and raised PRs with the correct procedure on all of them. There is also a possibility of some repos using strict versions for their own There is also a repo that uses a file named |
That PR is not an acceptable solution; OSD cannot make arbitrary changes to accommodate mistakes in CI scripts of plugins. |
@AMoo-Miki |
Should we also add the |
Kristen, my goal is relaxing all of these restrictions. If |
All new images for Jenkins have been deployed with yarn 1.22.19. |
❗This issue may block release
2.6
issue description
Multiple Dashboards plugins CI failure reported during plugin bootstrap step, after this commit to Dashboards core merged recently.
@opensearch-project/opensearch@2.1.0: The engine "yarn" is incompatible with this module. Expected version "^1.22.10". Got "1.21.1"
Root cause
The recent commit in OpenSearch Dashboards updates dependency @opensearch-project/opensearch from
^1.1.0
to^2.1.0
, where openearch-js2.1.0
specifiesyarn: ^1.22.1
, in this commit.Plugin CI workflow fetches yarn version from
Openesarch-Dashbaords/package.json
file, to set upyarn
, and still found 1.21.1. This is causing the yarn version incompatibility, and bootstrap will fail.Dashboards docker image, windows build scripts are using hardcoded yarn version, which will potentially be impacted, according to @peterzhuamazon
Impact
Proposed solution
yarn
version inpackage.json
to^1.22.1
Upgrade yarn version to be compatible with @openearch-project/opensearch OpenSearch-Dashboards#3443Openesarch-Dashbaords/package.json
, instead of hardcode.The text was updated successfully, but these errors were encountered: