You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
OSD provides a range in engines that works for OSD without considering deps or plugins. Sometimes, dependencies require higher versions of Yarn or Node.js and that is NOT reason enough for OSD to bump their engines. hence, the CI needs to use a version that works and will need to make adjustments deps evolve.
There is a counter argument that could be made that the lockfile dictates what OSD uses so it should make the best effort to satisfy those deps. I would argue against it that OSD plugins have deps that might not be common with OSD and those deps could impose their own engines; OSD cannot be expected to kep up with those.
Solution
Just like OSD does it, hardcode the version of Yarn. OSD uses nvm and .nvmrc; you could do the same, read the version from .nvmrc, or hardcode your own version of Node.js in the CI.
The text was updated successfully, but these errors were encountered:
What is the bug?
dashboards-observability/.github/workflows/dashboards-observability-test-and-build-workflow.yml
Lines 35 to 36 in 0527730
OSD provides a range in
engines
that works for OSD without considering deps or plugins. Sometimes, dependencies require higher versions of Yarn or Node.js and that is NOT reason enough for OSD to bump theirengines
. hence, the CI needs to use a version that works and will need to make adjustments deps evolve.There is a counter argument that could be made that the lockfile dictates what OSD uses so it should make the best effort to satisfy those deps. I would argue against it that OSD plugins have deps that might not be common with OSD and those deps could impose their own
engines
; OSD cannot be expected to kep up with those.Solution
Just like OSD does it, hardcode the version of Yarn. OSD uses
nvm
and.nvmrc
; you could do the same, read the version from.nvmrc
, or hardcode your own version of Node.js in the CI.The text was updated successfully, but these errors were encountered: