Fix Node.js and Yarn installation in CI #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miki <miki@amazon.com>
derek-ho
reviewed
Feb 22, 2023
Comment on lines
+46
to
+47
| - run: node -v | ||
| - run: yarn -v |
There was a problem hiding this comment.
@AMoo-Miki are these debug lines, if so can they be removed? I am approving the PR as is. It needs to be backported to major branches, thanks for the changes!
There was a problem hiding this comment.
Not strictly debug; I put them in all the repos as a way to monitor the version that was used since OSD asks for a range and the CI makes best effort to fulfill those requirements.
derek-ho
approved these changes
Feb 22, 2023
zhongnansu
approved these changes
Feb 22, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 22, 2023
Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit 3340703)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 22, 2023
Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit 3340703)
derek-ho
pushed a commit
that referenced
this pull request
Feb 22, 2023
derek-ho
pushed a commit
that referenced
this pull request
Feb 23, 2023
derek-ho
pushed a commit
to derek-ho/dashboards-observability
that referenced
this pull request
Feb 27, 2023
…nsearch-project#297) Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit 3340703) Co-authored-by: Miki <amoo_miki@yahoo.com>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…nsearch-project#297) Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit 3340703) Co-authored-by: Miki <amoo_miki@yahoo.com> (cherry picked from commit 87640b7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The GitHub workflow uses the
enginesfrom OSD incorrectly. This change fixes that.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.