Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped version to 3.0. #471

Merged
merged 2 commits into from
Apr 26, 2023
Merged

Conversation

AWSHurneyt
Copy link
Collaborator

Signed-off-by: AWSHurneyt hurneyt@amazon.com

Description

Bumped version to 3.0.

Issues Resolved

#290

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AWSHurneyt AWSHurneyt marked this pull request as ready for review January 31, 2023 19:18
@AWSHurneyt AWSHurneyt requested a review from a team January 31, 2023 19:18
@AWSHurneyt
Copy link
Collaborator Author

The cypress failures relating to ClusterMetricsMonitors were failing due to a bug introduced in common-utils 3.0. This PR fixes that bug opensearch-project/common-utils#359. Those cypress tests should succeed once the new 3.0 common-utils artifact is available.

@AWSHurneyt
Copy link
Collaborator Author

The test workflows are failing with the following error:

@opensearch-project/opensearch@2.1.0: The engine "yarn" is incompatible with this module. Expected version "^1.22.10". Got "1.21.1"

The changes in this PR don't seem to be the cause of that error though according to this issue. A solution is still being discussed.
opensearch-project/opensearch-build#3210

@lezzago
Copy link
Member

lezzago commented Apr 6, 2023

The problem issue has been merged, so will need to update this again.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #471 (d011f64) into main (23f7b01) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #471   +/-   ##
=======================================
  Coverage   52.82%   52.82%           
=======================================
  Files         212      212           
  Lines        5594     5594           
  Branches      782      782           
=======================================
  Hits         2955     2955           
  Misses       2637     2637           
  Partials        2        2           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AWSHurneyt
Copy link
Collaborator Author

The cypress tests workflow appears to be failing because the first few test suites are being executed before the domain has come up. However, because we don't guarantee stability on the main branches, we can review and merge in this bump, and resolve the workflow failures in a separate PR.

@AWSHurneyt AWSHurneyt marked this pull request as ready for review April 26, 2023 18:10
@AWSHurneyt AWSHurneyt merged commit d66bd60 into opensearch-project:main Apr 26, 2023
mjsell1234 pushed a commit to mjsell1234/alerting-dashboards-plugin that referenced this pull request Jun 14, 2023
* Bumped main to 3.0.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated snapshot.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

---------

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants