-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Upgrade yarn version to be compatible with @openearch-project/opensearch #3465
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would make sure to sign the last commit @zhongnansu or rebase onto the original commit.
Also, it appears that the OpenSearch JS bump caused a breaking change for downstream dependencies. And we have a revert commit on the way: 32944dd.
So probably best to hold off.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #3465 +/- ##
=======================================
Coverage 66.44% 66.44%
=======================================
Files 3205 3205
Lines 61567 61567
Branches 9497 9497
=======================================
Hits 40911 40911
Misses 18384 18384
Partials 2272 2272
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
We don't know if there will be feature break unless we run the plugin regression test after this PR merged in |
This change should not be necessary. OSD should not be bumping OSD should only, and only, bump these values when it truly requires something provided by the newer versions. |
PS, i messed up the original PR msg but tried to fix it; i think i got it right. |
Closing to avoid confusion. |
@kavilla The reverted commit was re-added to |
The same fix is merged in |
53112ca
to
ffb2f41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have raised PRs on all plugins that had flaws. This is not a problem that OSD has to or even can solve.
Backport d3fc27d from #3443.