-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add map as embeddable to dashboard #231
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #231 +/- ##
==========================================
+ Coverage 91.66% 91.79% +0.12%
==========================================
Files 10 10
Lines 264 268 +4
Branches 34 34
==========================================
+ Hits 242 246 +4
Misses 16 16
Partials 6 6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
245f7a8
to
fa30f8f
Compare
eb1e344
to
9fe327f
Compare
4f178f4
to
d319385
Compare
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
d319385
to
2218279
Compare
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
2218279
to
cb7f6d0
Compare
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
2621a43
to
ea4e575
Compare
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
ea4e575
to
5b0aa8a
Compare
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
6890102
to
c7f84bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The CI test failures aren’t related to this PR. Followed from opensearch-project/opensearch-build#3210 Unit tests and Cypress tests all passed at my local env |
From opensearch-project/oui#292 (comment), we will continue to use |
* Add map as embeddable to dashboard Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Create new map from dashboard visualization and save return Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Enable interval refresh in dashboard Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Enable filters in dashboard Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Enable query in dashboard Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Add cypress test Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Fix maps listing in visualization listing page Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Refactor controller Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Resolve feedback Signed-off-by: Junqiu Lei <junqiu@amazon.com> --------- Signed-off-by: Junqiu Lei <junqiu@amazon.com> (cherry picked from commit e48407b)
* Add map as embeddable to dashboard Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Create new map from dashboard visualization and save return Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Enable interval refresh in dashboard Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Enable filters in dashboard Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Enable query in dashboard Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Add cypress test Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Fix maps listing in visualization listing page Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Refactor controller Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Resolve feedback Signed-off-by: Junqiu Lei <junqiu@amazon.com> --------- Signed-off-by: Junqiu Lei <junqiu@amazon.com> (cherry picked from commit e48407b) Co-authored-by: Junqiu Lei <junqiu@amazon.com>
Signed-off-by: Junqiu Lei junqiu@amazon.com
Description
Allow user to add maps to dashboard. This PR contains:
Demo
Add existing map to dashboard
Screen.Recording.2023-02-07.at.11.55.47.AM.mov
Add new map from dashboard
Screen.Recording.2023-02-13.at.12.50.35.PM.mov
Issues Resolved
#214
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.