Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up sugar #106

Closed
3 tasks done
amtoine opened this issue Nov 22, 2023 · 0 comments · Fixed by #120
Closed
3 tasks done

clean up sugar #106

amtoine opened this issue Nov 22, 2023 · 0 comments · Fixed by #120
Assignees
Labels
enhancement New feature or request sugar Related to the `nu-git-manager-sugar` module

Comments

@amtoine
Copy link
Owner

amtoine commented Nov 22, 2023

the module has been left unchecked for too long 😏

@amtoine amtoine added enhancement New feature or request sugar Related to the `nu-git-manager-sugar` module labels Nov 22, 2023
@amtoine amtoine self-assigned this Nov 22, 2023
@amtoine amtoine mentioned this issue Nov 22, 2023
4 tasks
amtoine added a commit that referenced this issue Nov 22, 2023
related to
- #106

## description
this is an effort to
- [x] update the `nu-git-manager-sugar git` module
- [x] remove deprecated / useless commands
- [x] expose the meaningful ones as subcommands of `gm`
- [x] add tests when possible

### kept commands
- `get commit` -> `gm repo get commit`
- `root` -> `gm repo goto root`
- `branches` -> `gm repo branches`
- `is-ancestor` -> `gm repo is-ancestor`
- `remote list` -> `gm repo remote list`

### removed commands
- `operations`
- `compare`
- `lock clean`
- `remote add`
- `remote remove`
- `fixup`

### tests
a new `tests sugar git` module with
- `get-commit`
- `goto-root`
- `branches`
- `is-ancestor`
- `remote-list`
@amtoine amtoine pinned this issue Nov 22, 2023
amtoine added a commit that referenced this issue Nov 24, 2023
related to 
- #106

## description
this cleans up the `gh.nu` module into `github.nu` and will address one
task in #106

### new commands
- `gm gh query-api`: this is the biggest one which does all the API
heavy lifting
- `gm gh query-releases`
- `gm gh query-user`
- `gm gh pr checkout` inspired from old `me pr`

### removed commands
- all the old `gh.nu` module
- the now unused `fs/dir.nu` module

### tests
i don't think i'll add tests for that right now as the targets will be
moving 🤔
amtoine added a commit that referenced this issue Dec 3, 2023
should
- close #106 
 
# description
as `nu-git-manager-sugar gist` hasn't been touched since #26, it's old,
unmaintained, possibly broken and does not fit the _philosophy_ of NGM,
e.g. it does not export `gm ...` commands 🤔

this PR removes the `gist` module from `sugar` for now, until someone
can reimplement it and make sure it's functional 👍
@amtoine amtoine unpinned this issue Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sugar Related to the `nu-git-manager-sugar` module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant