clean sugar github
#31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
after that PR, i'll add the new feature from nushell/nushell#11057 to simplify the |
This reverts commit 4e608e8.
amtoine
added a commit
to amtoine/dotfiles
that referenced
this pull request
Nov 24, 2023
amtoine
added a commit
that referenced
this pull request
Nov 24, 2023
related to - #31 ## description i found two bugs when using `gm gh pr checkout` - in `nu-git-manager`, i pressed escape in `input list` and there was no early `return` => the command crashed on `$res.id` - in `nushell`, my GitHub remote repo was incorrectly set to `amtoine/nushell` => the command crashed because the PR table was empty this PR fixes those two bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to
sugar#106description
this cleans up the
gh.numodule intogithub.nuand will address one task in #106new commands
gm gh query-api: this is the biggest one which does all the API heavy liftinggm gh query-releasesgm gh query-usergm gh pr checkoutinspired from oldme prremoved commands
gh.numodulefs/dir.numoduletests
i don't think i'll add tests for that right now as the targets will be moving 🤔