Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix joblib.Memory no longer supports cachedir argument #24

Closed
wants to merge 2 commits into from

Conversation

jilv220
Copy link

@jilv220 jilv220 commented Oct 11, 2022

@amueller
Copy link
Owner

Thank you for the fix. Can you maybe just remove the keyword instead of defining a variable? Also, does passing it positionally work for both the old and the new version?

@jilv220
Copy link
Author

jilv220 commented Oct 21, 2022

Seems it worked for both the old and the new version.

I tested import mglearn with both joblib version 1.1.1 and 1.2.0.

@jilv220
Copy link
Author

jilv220 commented Oct 21, 2022

Sorry with the late reply. I was busy doing course works before.

@g-cqd
Copy link

g-cqd commented Nov 28, 2022

Could this be pushed to the pip repository please ?

@amueller
Copy link
Owner

amueller commented Jun 1, 2023

sorry for the slow response, should be fixed now, I'll upload it to pipy shortly.

@amueller amueller closed this Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants