-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Atlas Lineage support #1103
Conversation
4a30e61
to
be0eefa
Compare
b11f4a1
to
bce0a3d
Compare
bce0a3d
to
ef7381b
Compare
cc @verdan |
a0a7e76
to
9e7566e
Compare
metadata/requirements.txt
Outdated
@@ -35,7 +35,7 @@ typing-extensions==3.7.4 | |||
|
|||
# A common package that holds the models deifnition and schemas that are used | |||
# accross different amundsen repositories. | |||
amundsen-common>=0.11.0 | |||
amundsen-common>=0.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this must be at least 0.10.1 in order to work with lineage.
0.10.1 introduced the parent
field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep it's just temporary as 0.11.0 is not yet published (but already hit main), agree it needs to be reverted before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
11 has been published 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, rebased!
statistics = list() | ||
|
||
badges = list() | ||
for column_classification in col_entity.get('classifications') or list(): | ||
if column_classification.get('entityStatus') == Status.ACTIVE: | ||
if column_classification.get('entityStatus') == AtlasStatus.ACTIVE: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: this can also be a utility method in amundsen common to check if the entity is active. This is being used in this proxy in a number of places.
entity.is_active()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've generalized most of it by introducing _filter_active
helper metod in AtlasProxy
. Remaining cases of using explicit == AtlasStatus.ACTIVE
would not be easily generalized as:
- there are only 4 comparisons
== AtlasStatus.ACTIVE
outside_filter_active
- 2 out of those 4 rely on
entity.status
property - 1 of those 4 rely on
enitity.get('entityStatus')
value (which cannot be retrieved with.status
) - 1 of those 4 rely on
entity.get('relationshipStatus')
value
so there is no more room for generalization IMO
e2c3590
to
9fc2f47
Compare
4c68b26
to
a821e49
Compare
Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com>
Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com>
Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com>
Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com>
Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com>
Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com>
Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com>
Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com>
Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com>
a821e49
to
9ee4031
Compare
@@ -0,0 +1,245 @@ | |||
# Copyright Contributors to the Amundsen project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mgorsk1 you don't need to name this atlas_utils
, as this is clear that the file is under /utils directory.
I'd rename this to atlas.py
only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, i'll let @dechoma fix this :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit. Please feel free to merge directly if you think otherwise. 🙂
introduces support for lineage in atlas metadata proxy
introduces support for lineage in atlas metadata proxy
introduces support for lineage in atlas metadata proxy Signed-off-by: dechoma <dominik.choma@gmail.com>
introduces support for lineage in atlas metadata proxy Signed-off-by: dechoma <dominik.choma@gmail.com>
introduces support for lineage in atlas metadata proxy Signed-off-by: dechoma <dominik.choma@gmail.com>
* feat: Apache Superset Extractor (amundsen-io#1076) Adds support for syncing dashboard metadata from Apache Superset. * boring_cyborg | 🎉 Initial commit. (amundsen-io#1101) Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * fix: Try to use the app context (amundsen-io#1102) Signed-off-by: verdan <verdan.mahmood@gmail.com> * feat: Apache Superset UI Icons (amundsen-io#1100) adds Apache Superset icons to frontend * feat: Pre-work needed for the lineage graph visualization (amundsen-io#1084) * parent f6b21b3 author verdan <verdan.mahmood@gmail.com> 1620122095 +0200 committer verdan <verdan.mahmood@gmail.com> 1620776994 +0200 initial commit Fixes the lineage query, updates the common model more updates updates the look and feel removes commented code Signed-off-by: verdan <verdan.mahmood@gmail.com> passes the paramters to backend adds the zooming feature code refactor, addresses review comments Signed-off-by: verdan <verdan.mahmood@gmail.com> docs: update faq.md (amundsen-io#1038) Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> Modified methods to throw NOTFOUNDEXCEPTION instead RuntimeEror in neo4j_proxy (metadata_service) (amundsen-io#1028) Signed-off-by: aparna-cimpress <aparna.singhal@cimpress.com> perf: Update ModeDashboardLastModifiedTimestampExtractor to use Mode discovery api (amundsen-io#1040) * update ModeDashboardLastModifiedTimestampExtractor to use Mode discovery api Signed-off-by: Junda Yang <youngyjd@gmail.com> * add empty line at the end of the file Signed-off-by: Junda Yang <youngyjd@gmail.com> * update comment Signed-off-by: Junda Yang <youngyjd@gmail.com> * fix lint Signed-off-by: Junda Yang <youngyjd@gmail.com> * fix import Signed-off-by: Junda Yang <youngyjd@gmail.com> ci: fix metadata ci config (amundsen-io#1039) Signed-off-by: Dorian Johnson <2020@dorianj.net> perf: update ModeDashboardLastSuccessfulExecutionExtractor to discovery api (amundsen-io#1042) * update ModeDashboardLastSuccessfulExecutionExtractor to discovery api Signed-off-by: Junda Yang <youngyjd@gmail.com> * lint Signed-off-by: Junda Yang <youngyjd@gmail.com> * remove unused import Signed-off-by: Junda Yang <youngyjd@gmail.com> perf: Update ModeDashboardOwner extractor to use Mode discovery api (amundsen-io#1043) * update ModeDashboardOwnerExtractor to discovery api Signed-off-by: Junda Yang <youngyjd@gmail.com> * update import Signed-off-by: Junda Yang <youngyjd@gmail.com> update ModeDashboardQueryExtractor to discovery api (amundsen-io#1044) Signed-off-by: Junda Yang <youngyjd@gmail.com> chore: fix databuilder dep typo (amundsen-io#1046) Signed-off-by: feng-tao <fengtao04@gmail.com> build(deps): bump py from 1.5.3 to 1.10.0 in /databuilder (amundsen-io#1049) chore: Update ModeDashboardLastModifiedTimestampExtractor typing (amundsen-io#1048) update Mode dashboard extractor tests (amundsen-io#1047) fix: Temporarily fix potential 404 in mode dashboard executions extractor (amundsen-io#1051) * fix ModeDashboardExecutionsExtractor Signed-off-by: Junda Yang <youngyjd@gmail.com> * nit Signed-off-by: Junda Yang <youngyjd@gmail.com> test: refactor: update test and directory of ModeDashboardChartsBatchExtractor (amundsen-io#1052) Temporarily fix potential 404 in ModeDashboardUsageExtractor (amundsen-io#1053) feat: Add dbt extractor for table lineage + metadata (amundsen-io#1015) * converted dbt extractor to mono repo Signed-off-by: Grant Seward <grant@stemma.ai> * Flake8 formatting Signed-off-by: Grant Seward <grant@stemma.ai> * Updates per feedback from Convoy Signed-off-by: Grant Seward <grant@stemma.ai> * Commented sample logging Signed-off-by: Grant Seward <grant@stemma.ai> * Added dbt to main amundsen README Signed-off-by: Grant Seward <grant@stemma.ai> fix bug in rest_api_query (amundsen-io#1056) Signed-off-by: Junda Yang <youngyjd@gmail.com> feat: Add merge query results functionality to rest_api_query (amundsen-io#1058) * Add merge query results functionality Signed-off-by: Junda Yang <youngyjd@gmail.com> * fix mypy Signed-off-by: Junda Yang <youngyjd@gmail.com> * nit Signed-off-by: Junda Yang <youngyjd@gmail.com> chore: fix gh page build workflow (amundsen-io#1062) Signed-off-by: feng-tao <fengtao04@gmail.com> chore: add mailmap to associate the right user (amundsen-io#1061) Signed-off-by: feng-tao <fengtao04@gmail.com> fix: Update ModeDashboardExtractor to Mode discovery api (amundsen-io#1063) * Update ModeDashboardExtractor to Mode discovery api Signed-off-by: Junda Yang <youngyjd@gmail.com> * nit Signed-off-by: Junda Yang <youngyjd@gmail.com> chore: delete legacy ModeDashboardChartsExtractor (amundsen-io#1064) * remove-legacy-charts-extractor Signed-off-by: Junda Yang <youngyjd@gmail.com> * nit Signed-off-by: Junda Yang <youngyjd@gmail.com> bump up databuilder version (amundsen-io#1065) Signed-off-by: Junda Yang <youngyjd@gmail.com> fix in another PR Signed-off-by: verdan <verdan.mahmood@gmail.com> makes Verdan and Dorian the code owners (amundsen-io#1081) Signed-off-by: verdan <verdan.mahmood@gmail.com> Adds a new "parent" field in lineage model (amundsen-io#1080) * adds 'parent' field to help build the graph Signed-off-by: verdan <verdan.mahmood@gmail.com> * make the default to None Signed-off-by: verdan <verdan.mahmood@gmail.com> deploy_release: on release, publish to pypi/docker (amundsen-io#1079) Given a release with a title of `<module_name> <version_number>`, this will push that release to PyPi and docker. Note that this does not attempt to create the changelog or any of that stuff. That will need to be done by a separate action. This creates a nice modularity boundary, in that this action doesn't care where the release came from (manual or another automated step) Signed-off-by: Dorian Johnson <2020@dorianj.net> Fixes the test cases Signed-off-by: verdan <verdan.mahmood@gmail.com> Removes extra functionality Signed-off-by: verdan <verdan.mahmood@gmail.com> removes redundant flag Signed-off-by: verdan <verdan.mahmood@gmail.com> * FIxes the betterer issues Signed-off-by: verdan <verdan.mahmood@gmail.com> * code review changes Signed-off-by: verdan <verdan.mahmood@gmail.com> * updates the common version Signed-off-by: verdan <verdan.mahmood@gmail.com> * Fixes lint errors for metadata Signed-off-by: verdan <verdan.mahmood@gmail.com> * feat: Atlas Dashboard Support (amundsen-io#1066) - metadata: extended atlas proxy with dashboard support - databuilder: extended atlas search extractor with dashboard support * feat: ML Features common schema and metadata API definition (amundsen-io#1059) * feature model Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * feature model lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added query schema Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * reorder Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * metadata swagger template Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * stubbing out all classes and methods Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Created models for tabs, stubbed out all API methods Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * defined feature API routes Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * bumped common version Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more specific type Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * workflow change Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * isort Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * badge import and tag import chnages Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed imports Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * small fixes Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added standalone query file to common Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fix: dashboard in atlas metadata proxy (amundsen-io#1110) Signed-off-by: DOMINIK CHOMA <dominik.choma@ing.com> * Fix: Update Amundsen Common to 0.11.0 (amundsen-io#1088) * Update amundsen-common version to '0.10.0' Signed-off-by: Kevin Dukelow <Kevin_Dukelow@colpal.com> * Update search and metadata services Signed-off-by: Kevin Dukelow <Kevin_Dukelow@colpal.com> * Update to 0.11.0 Signed-off-by: Kevin Dukelow <Kevin_Dukelow@colpal.com> * feat: Implement ML Feature Details API (amundsen-io#1091) * feature model Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * feature model lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added query schema Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * reorder Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * metadata swagger template Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * stubbing out all classes and methods Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Created models for tabs, stubbed out all API methods Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * defined feature API routes Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * bumped common version Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more specific type Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Started implwementation Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * workflow change Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * isort Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * badge import and tag import chnages Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed imports Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * small fixes Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * functional, need to verify structure, finish up some queries, and write tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * looks fully functional Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fully functional details Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * cleaned up a bit Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint and start testing Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added standalone query file to common Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * tests and some small changes Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * made _exec_feature_query less complex Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added type annotation to classify tags arg Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed import order Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added final except and fixed query order Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * created methods to extract objects from neo4j query Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * pinned common version in FE to latest Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Update search PR workflow to use search directory (amundsen-io#1112) Signed-off-by: Grant Seward <grant@stemma.ai> * perf: Update ModeDashboardUsageExtractor to discovery endpoint (amundsen-io#1115) * move mode dashboard usage extractor to discovery api Signed-off-by: Junda Yang <youngyjd@gmail.com> * update Signed-off-by: Junda Yang <youngyjd@gmail.com> * mock post process Signed-off-by: Junda Yang <youngyjd@gmail.com> * fix test Signed-off-by: Junda Yang <youngyjd@gmail.com> * solve lint error Signed-off-by: Junda Yang <youngyjd@gmail.com> * fix isort Signed-off-by: Junda Yang <youngyjd@gmail.com> * perf: Update mode dashboard executions extractor to discovery api (amundsen-io#1116) * update ModeDashboardExecutionsExtractor to discovery api Signed-off-by: Junda Yang <youngyjd@gmail.com> * update README Signed-off-by: Junda Yang <youngyjd@gmail.com> * feat: Implement Feature Tag, Badge, Description and Owner APIs (amundsen-io#1108) * feature model Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * feature model lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added query schema Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * reorder Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * metadata swagger template Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * stubbing out all classes and methods Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Created models for tabs, stubbed out all API methods Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * defined feature API routes Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * bumped common version Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more specific type Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Started implwementation Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * workflow change Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * isort Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * badge import and tag import chnages Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed imports Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * small fixes Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * functional, need to verify structure, finish up some queries, and write tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * looks fully functional Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fully functional details Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * cleaned up a bit Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint and start testing Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added standalone query file to common Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * tests and some small changes Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * made _exec_feature_query less complex Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added type annotation to classify tags arg Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed import order Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * implemented feature badge API Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * implementing more feature APIs Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * manual testing and fixed bug Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added final except and fixed query order Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * created methods to extract objects from neo4j query Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * pinned common version in FE to latest Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * description API works Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * functional owners API Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * reverted and added separate method Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * cleaning up Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added from base proxy Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more to base proxy and other proxies Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * reuse code Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * uodated test Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * cleanup Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oops Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added logging Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated comment Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fix: handle columns in manifest and not in catalog (amundsen-io#1095) Signed-off-by: Adam Boscarino <aboscarino@devoted.com> * boring-cyborg: make it a bit friendlier (amundsen-io#1123) Given that this doesn't actually check if people filled out the issue template, I think it's a bit unfriendly. I also don't think it will change behavior for people who don't follow the template Signed-off-by: Dorian Johnson <2020@dorianj.net> * feat: ML Feature Generation Code API (amundsen-io#1122) * WIP not functional Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * still wip Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Functional generation code API Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added method to base proxy and others Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * space Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * whitespace Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * eliminated weirdness Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * unit tests!' Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * isort Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fix: Database filter to return string, not object (amundsen-io#1041) * Database filter returns string not object Signed-off-by: Grant Seward <grant@stemma.ai> * Added comma to fix syntax text Signed-off-by: Grant Seward <grant@stemma.ai> * docs: update databuilder directory name after deprecating databuilder submodule (amundsen-io#1106) Signed-off-by: Marcin Mazurek <marcin@mazurek.pro> * docs: fix some broken links (amundsen-io#1125) Signed-off-by: Dorian Johnson <2020@dorianj.net> * update ModePaginatedRestApiQuery default parameterrs (amundsen-io#1126) Signed-off-by: Junda Yang <youngyjd@gmail.com> * Fix: Make BigQuery extractors support Relational Metadata store (amundsen-io#1109) * Modify Watermark extractor to support relational metadata store Signed-off-by: Sahithi Velma <sahithiv@wepay.com> * Modify BigQuery Usage extractor to support relational metadata store Signed-off-by: Sahithi Velma <sahithiv@wepay.com> * Modify BigQuery Usage extractor to only count usage of tables present in the project_id_key Signed-off-by: Sahithi Velma <sahithiv@wepay.com> Co-authored-by: Sahithi Velma <sahithiv@wepay.com> * feat: Pandas-Profiling TableColumnStats Extractor (amundsen-io#1105) introduces pandas-profiling based extractor for table column stats * feat: support skipping configured Mode spaces (amundsen-io#1129) * bump up databuilder version to 4.4.1 (amundsen-io#1130) * fix typo aws_secret_access_key in neptune csv publisher (amundsen-io#1134) Signed-off-by: iamtodor <todor.ilya@gmail.com> * fix: search_table API swagger file bug fix (amundsen-io#1120) * search table swagger file bug fix Signed-off-by: nishant_cimpress <nishant.sharma@cimpress.com> * removed comment Signed-off-by: nishant_cimpress <nishant.sharma@cimpress.com> Co-authored-by: nishant_cimpress <nishant.sharma@cimpress.com> * feat: Atlas Lineage support (amundsen-io#1103) introduces support for lineage in atlas metadata proxy * fix: atlas proxy fix (amundsen-io#1139) Signed-off-by: dechoma <dominik.choma@gmail.com> * feat: use chart_names in dashboard basic search (amundsen-io#1140) Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * fix: pytest setup.cfg section fix (amundsen-io#1144) Signed-off-by: Jakub Nowacki <j.s.nowacki@gmail.com> * chore: remove a comment that conflicts with implementation (amundsen-io#1154) Signed-off-by: Tero Paananen <tpaananen@bloomberg.net> * feat: Common query models (amundsen-io#1155) * Added join and where models for how tables are joined / filtered with sql Signed-off-by: Grant Seward <grant@stemma.ai> * removed addl space Signed-off-by: Grant Seward <grant@stemma.ai> * version bump Signed-off-by: Grant Seward <grant@stemma.ai> * feat: Configuration option to init custom routes (amundsen-io#1160) * configuration option to init custom routes Signed-off-by: verdan <verdan.mahmood@gmail.com> * Fixes isort Signed-off-by: verdan <verdan.mahmood@gmail.com> * :sigh: really fixes isort Signed-off-by: verdan <verdan.mahmood@gmail.com> * feat: Search service adding suport for AWS Elasticsearch (amundsen-io#1141) Signed-off-by: Jakub Nowacki <j.s.nowacki@gmail.com> * Fix installation link (amundsen-io#1159) The link was broken Signed-off-by: Fokko Driesprong <fokko@datafold.com> * fix: 1157 issude - metadata sql alchemy for iodc component (amundsen-io#1169) Signed-off-by: iamtodor <todor.ilya@gmail.com> * Helm service versions moved up to latest ones (amundsen-io#1165) Signed-off-by: Jakub Nowacki <j.s.nowacki@gmail.com> * Fix doc links in README.md (amundsen-io#1164) Just a quick driveby to fix a few doc links that still point to old locations. Signed-off-by: James Davidheiser <jamesdavidheiser@asana.com> * fix: aws_config (amundsen-io#1167) Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * fix: add optional list to atlas_search_extractor (amundsen-io#1180) Signed-off-by: dechoma <dominik.choma@gmail.com> * feat: introduce atlas serializable for dashboards (amundsen-io#1138) Signed-off-by: dechoma <dominik.choma@gmail.com> * build(deps): bump amundsenrds from `589be11` to `4509bb0` (amundsen-io#1174) Bumps [amundsenrds](https://github.com/amundsen-io/amundsenrds) from `589be11` to `4509bb0`. - [Release notes](https://github.com/amundsen-io/amundsenrds/releases) - [Commits](amundsen-io/amundsenrds@589be11...4509bb0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * chore: bump up amundsen_common to 0.13.0 (amundsen-io#1183) Signed-off-by: dechoma <dominik.choma@gmail.com> * fix: add amundsen-common requirement (amundsen-io#1184) Signed-off-by: dechoma <dominik.choma@gmail.com> * feat: support mysql in metadata service (amundsen-io#1182) * support metadata service for mysql Signed-off-by: xuans <xuan_shen@outlook.com> * update doc Signed-off-by: xuans <xuan_shen@outlook.com> * fixed some typo in doc Signed-off-by: xuans <xuan_shen@outlook.com> * Add configurable cli registration Signed-off-by: xuans <xuan_shen@outlook.com> * test: Increase test coverage for atlas proxy (amundsen-io#1173) Signed-off-by: sinkuladis <sink.vlad@gmail.com> * Fix broken anchor link in readme (amundsen-io#1193) the section anchor for troubleshoot section is broken, I added the correct anchor. Signed-off-by: qiman-wang <wangqiman0111@gmail.com> * chore: update requirement file in metadata (amundsen-io#1194) * chore: update requirement file in metadata Signed-off-by: feng-tao <fengtao04@gmail.com> * chore: update CI Signed-off-by: feng-tao <fengtao04@gmail.com> * update version Signed-off-by: feng-tao <fengtao04@gmail.com> * Docs: add AWS Neptune to metadata*s Readme (amundsen-io#1197) * add AWS Neptune to metadata*s Readme Signed-off-by: iamtodor <todor.ilya@gmail.com> * Update README.md Co-authored-by: Tao Feng <tfeng@apache.org> * feat: Add databuilder models for Feature (amundsen-io#1201) * [feat] Add databuilder models for Feature Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * add feature model docs Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * fix dashboard owner test Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * lint failures Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * docstring improvements Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * bump version Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * feat: Generic Usage Extractor (amundsen-io#1199) Signed-off-by: Allison Doami <adoami@chanzuckerberg.com> * add information about default ES indexes to search Readme (amundsen-io#1198) Signed-off-by: iamtodor <todor.ilya@gmail.com> * chore: add myself as codeowner for other services (amundsen-io#1204) Signed-off-by: Dorian Johnson <2020@dorianj.net> * Add backwards compatible support for Jira cloud/hosted. (amundsen-io#1207) Signed-off-by: BB <boyan@typed.wtf> * adds the test cases Signed-off-by: verdan <verdan.mahmood@gmail.com> * removes the duplicated file Signed-off-by: verdan <verdan.mahmood@gmail.com> * fixes mypy Signed-off-by: verdan <verdan.mahmood@gmail.com> Co-authored-by: mgorsk1 <gorskimariusz13@gmail.com> Co-authored-by: Allison Suarez Miranda <22477579+allisonsuarez@users.noreply.github.com> Co-authored-by: dechoma <dominik.choma@gmail.com> Co-authored-by: KevinDukelow5 <Kevin_dukelow@colpal.com> Co-authored-by: sewardgw <grant@stemma.ai> Co-authored-by: Junda Yang <youngyjd@gmail.com> Co-authored-by: Adam Boscarino <aboscarino@devoted.com> Co-authored-by: Dorian Johnson <2020@dorianj.net> Co-authored-by: Marcin Mazurek <marcin@mazurek.pro> Co-authored-by: Sahithi Reddy Velma <46659774+sahithi03@users.noreply.github.com> Co-authored-by: Sahithi Velma <sahithiv@wepay.com> Co-authored-by: iamtodor <todor.ilya@gmail.com> Co-authored-by: Nishant Sharma <nishantmaharishi@gmail.com> Co-authored-by: nishant_cimpress <nishant.sharma@cimpress.com> Co-authored-by: Jakub Nowacki <j.s.nowacki@gmail.com> Co-authored-by: gorbachev <tpp+github@iki.fi> Co-authored-by: Fokko Driesprong <fokko@driesprong.frl> Co-authored-by: James Davidheiser <jdavidheiser@users.noreply.github.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Xuan <65048031+crazy-2020@users.noreply.github.com> Co-authored-by: sinkuladis <sink.vlad@gmail.com> Co-authored-by: QimanWang <wangqiman0111@gmail.com> Co-authored-by: Tao Feng <fengtao04@gmail.com> Co-authored-by: Tao Feng <tfeng@apache.org> Co-authored-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> Co-authored-by: Allison Doami <adoami@chanzuckerberg.com> Co-authored-by: Boyan Bonev <bbsbb@users.noreply.github.com>
* feat: Apache Superset Extractor (amundsen-io#1076) Adds support for syncing dashboard metadata from Apache Superset. * boring_cyborg | 🎉 Initial commit. (amundsen-io#1101) Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * fix: Try to use the app context (amundsen-io#1102) Signed-off-by: verdan <verdan.mahmood@gmail.com> * feat: Apache Superset UI Icons (amundsen-io#1100) adds Apache Superset icons to frontend * feat: Pre-work needed for the lineage graph visualization (amundsen-io#1084) * parent f6b21b3 author verdan <verdan.mahmood@gmail.com> 1620122095 +0200 committer verdan <verdan.mahmood@gmail.com> 1620776994 +0200 initial commit Fixes the lineage query, updates the common model more updates updates the look and feel removes commented code Signed-off-by: verdan <verdan.mahmood@gmail.com> passes the paramters to backend adds the zooming feature code refactor, addresses review comments Signed-off-by: verdan <verdan.mahmood@gmail.com> docs: update faq.md (amundsen-io#1038) Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> Modified methods to throw NOTFOUNDEXCEPTION instead RuntimeEror in neo4j_proxy (metadata_service) (amundsen-io#1028) Signed-off-by: aparna-cimpress <aparna.singhal@cimpress.com> perf: Update ModeDashboardLastModifiedTimestampExtractor to use Mode discovery api (amundsen-io#1040) * update ModeDashboardLastModifiedTimestampExtractor to use Mode discovery api Signed-off-by: Junda Yang <youngyjd@gmail.com> * add empty line at the end of the file Signed-off-by: Junda Yang <youngyjd@gmail.com> * update comment Signed-off-by: Junda Yang <youngyjd@gmail.com> * fix lint Signed-off-by: Junda Yang <youngyjd@gmail.com> * fix import Signed-off-by: Junda Yang <youngyjd@gmail.com> ci: fix metadata ci config (amundsen-io#1039) Signed-off-by: Dorian Johnson <2020@dorianj.net> perf: update ModeDashboardLastSuccessfulExecutionExtractor to discovery api (amundsen-io#1042) * update ModeDashboardLastSuccessfulExecutionExtractor to discovery api Signed-off-by: Junda Yang <youngyjd@gmail.com> * lint Signed-off-by: Junda Yang <youngyjd@gmail.com> * remove unused import Signed-off-by: Junda Yang <youngyjd@gmail.com> perf: Update ModeDashboardOwner extractor to use Mode discovery api (amundsen-io#1043) * update ModeDashboardOwnerExtractor to discovery api Signed-off-by: Junda Yang <youngyjd@gmail.com> * update import Signed-off-by: Junda Yang <youngyjd@gmail.com> update ModeDashboardQueryExtractor to discovery api (amundsen-io#1044) Signed-off-by: Junda Yang <youngyjd@gmail.com> chore: fix databuilder dep typo (amundsen-io#1046) Signed-off-by: feng-tao <fengtao04@gmail.com> build(deps): bump py from 1.5.3 to 1.10.0 in /databuilder (amundsen-io#1049) chore: Update ModeDashboardLastModifiedTimestampExtractor typing (amundsen-io#1048) update Mode dashboard extractor tests (amundsen-io#1047) fix: Temporarily fix potential 404 in mode dashboard executions extractor (amundsen-io#1051) * fix ModeDashboardExecutionsExtractor Signed-off-by: Junda Yang <youngyjd@gmail.com> * nit Signed-off-by: Junda Yang <youngyjd@gmail.com> test: refactor: update test and directory of ModeDashboardChartsBatchExtractor (amundsen-io#1052) Temporarily fix potential 404 in ModeDashboardUsageExtractor (amundsen-io#1053) feat: Add dbt extractor for table lineage + metadata (amundsen-io#1015) * converted dbt extractor to mono repo Signed-off-by: Grant Seward <grant@stemma.ai> * Flake8 formatting Signed-off-by: Grant Seward <grant@stemma.ai> * Updates per feedback from Convoy Signed-off-by: Grant Seward <grant@stemma.ai> * Commented sample logging Signed-off-by: Grant Seward <grant@stemma.ai> * Added dbt to main amundsen README Signed-off-by: Grant Seward <grant@stemma.ai> fix bug in rest_api_query (amundsen-io#1056) Signed-off-by: Junda Yang <youngyjd@gmail.com> feat: Add merge query results functionality to rest_api_query (amundsen-io#1058) * Add merge query results functionality Signed-off-by: Junda Yang <youngyjd@gmail.com> * fix mypy Signed-off-by: Junda Yang <youngyjd@gmail.com> * nit Signed-off-by: Junda Yang <youngyjd@gmail.com> chore: fix gh page build workflow (amundsen-io#1062) Signed-off-by: feng-tao <fengtao04@gmail.com> chore: add mailmap to associate the right user (amundsen-io#1061) Signed-off-by: feng-tao <fengtao04@gmail.com> fix: Update ModeDashboardExtractor to Mode discovery api (amundsen-io#1063) * Update ModeDashboardExtractor to Mode discovery api Signed-off-by: Junda Yang <youngyjd@gmail.com> * nit Signed-off-by: Junda Yang <youngyjd@gmail.com> chore: delete legacy ModeDashboardChartsExtractor (amundsen-io#1064) * remove-legacy-charts-extractor Signed-off-by: Junda Yang <youngyjd@gmail.com> * nit Signed-off-by: Junda Yang <youngyjd@gmail.com> bump up databuilder version (amundsen-io#1065) Signed-off-by: Junda Yang <youngyjd@gmail.com> fix in another PR Signed-off-by: verdan <verdan.mahmood@gmail.com> makes Verdan and Dorian the code owners (amundsen-io#1081) Signed-off-by: verdan <verdan.mahmood@gmail.com> Adds a new "parent" field in lineage model (amundsen-io#1080) * adds 'parent' field to help build the graph Signed-off-by: verdan <verdan.mahmood@gmail.com> * make the default to None Signed-off-by: verdan <verdan.mahmood@gmail.com> deploy_release: on release, publish to pypi/docker (amundsen-io#1079) Given a release with a title of `<module_name> <version_number>`, this will push that release to PyPi and docker. Note that this does not attempt to create the changelog or any of that stuff. That will need to be done by a separate action. This creates a nice modularity boundary, in that this action doesn't care where the release came from (manual or another automated step) Signed-off-by: Dorian Johnson <2020@dorianj.net> Fixes the test cases Signed-off-by: verdan <verdan.mahmood@gmail.com> Removes extra functionality Signed-off-by: verdan <verdan.mahmood@gmail.com> removes redundant flag Signed-off-by: verdan <verdan.mahmood@gmail.com> * FIxes the betterer issues Signed-off-by: verdan <verdan.mahmood@gmail.com> * code review changes Signed-off-by: verdan <verdan.mahmood@gmail.com> * updates the common version Signed-off-by: verdan <verdan.mahmood@gmail.com> * Fixes lint errors for metadata Signed-off-by: verdan <verdan.mahmood@gmail.com> * feat: Atlas Dashboard Support (amundsen-io#1066) - metadata: extended atlas proxy with dashboard support - databuilder: extended atlas search extractor with dashboard support * feat: ML Features common schema and metadata API definition (amundsen-io#1059) * feature model Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * feature model lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added query schema Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * reorder Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * metadata swagger template Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * stubbing out all classes and methods Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Created models for tabs, stubbed out all API methods Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * defined feature API routes Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * bumped common version Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more specific type Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * workflow change Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * isort Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * badge import and tag import chnages Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed imports Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * small fixes Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added standalone query file to common Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fix: dashboard in atlas metadata proxy (amundsen-io#1110) Signed-off-by: DOMINIK CHOMA <dominik.choma@ing.com> * Fix: Update Amundsen Common to 0.11.0 (amundsen-io#1088) * Update amundsen-common version to '0.10.0' Signed-off-by: Kevin Dukelow <Kevin_Dukelow@colpal.com> * Update search and metadata services Signed-off-by: Kevin Dukelow <Kevin_Dukelow@colpal.com> * Update to 0.11.0 Signed-off-by: Kevin Dukelow <Kevin_Dukelow@colpal.com> * feat: Implement ML Feature Details API (amundsen-io#1091) * feature model Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * feature model lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added query schema Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * reorder Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * metadata swagger template Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * stubbing out all classes and methods Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Created models for tabs, stubbed out all API methods Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * defined feature API routes Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * bumped common version Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more specific type Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Started implwementation Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * workflow change Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * isort Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * badge import and tag import chnages Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed imports Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * small fixes Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * functional, need to verify structure, finish up some queries, and write tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * looks fully functional Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fully functional details Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * cleaned up a bit Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint and start testing Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added standalone query file to common Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * tests and some small changes Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * made _exec_feature_query less complex Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added type annotation to classify tags arg Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed import order Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added final except and fixed query order Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * created methods to extract objects from neo4j query Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * pinned common version in FE to latest Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Update search PR workflow to use search directory (amundsen-io#1112) Signed-off-by: Grant Seward <grant@stemma.ai> * perf: Update ModeDashboardUsageExtractor to discovery endpoint (amundsen-io#1115) * move mode dashboard usage extractor to discovery api Signed-off-by: Junda Yang <youngyjd@gmail.com> * update Signed-off-by: Junda Yang <youngyjd@gmail.com> * mock post process Signed-off-by: Junda Yang <youngyjd@gmail.com> * fix test Signed-off-by: Junda Yang <youngyjd@gmail.com> * solve lint error Signed-off-by: Junda Yang <youngyjd@gmail.com> * fix isort Signed-off-by: Junda Yang <youngyjd@gmail.com> * perf: Update mode dashboard executions extractor to discovery api (amundsen-io#1116) * update ModeDashboardExecutionsExtractor to discovery api Signed-off-by: Junda Yang <youngyjd@gmail.com> * update README Signed-off-by: Junda Yang <youngyjd@gmail.com> * feat: Implement Feature Tag, Badge, Description and Owner APIs (amundsen-io#1108) * feature model Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * feature model lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added query schema Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * reorder Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * metadata swagger template Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * stubbing out all classes and methods Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Created models for tabs, stubbed out all API methods Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * defined feature API routes Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * bumped common version Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more specific type Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Started implwementation Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * workflow change Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * isort Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * badge import and tag import chnages Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed imports Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * small fixes Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * functional, need to verify structure, finish up some queries, and write tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * looks fully functional Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fully functional details Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * cleaned up a bit Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint and start testing Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added standalone query file to common Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * tests and some small changes Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * made _exec_feature_query less complex Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added type annotation to classify tags arg Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed import order Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * implemented feature badge API Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * implementing more feature APIs Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * manual testing and fixed bug Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added final except and fixed query order Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * created methods to extract objects from neo4j query Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * pinned common version in FE to latest Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * description API works Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * functional owners API Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * reverted and added separate method Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * cleaning up Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added from base proxy Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more to base proxy and other proxies Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * reuse code Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * uodated test Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added unit tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * cleanup Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oops Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added logging Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated comment Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fix: handle columns in manifest and not in catalog (amundsen-io#1095) Signed-off-by: Adam Boscarino <aboscarino@devoted.com> * boring-cyborg: make it a bit friendlier (amundsen-io#1123) Given that this doesn't actually check if people filled out the issue template, I think it's a bit unfriendly. I also don't think it will change behavior for people who don't follow the template Signed-off-by: Dorian Johnson <2020@dorianj.net> * feat: ML Feature Generation Code API (amundsen-io#1122) * WIP not functional Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * still wip Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Functional generation code API Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added method to base proxy and others Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * space Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * whitespace Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * eliminated weirdness Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * unit tests!' Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * isort Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fix: Database filter to return string, not object (amundsen-io#1041) * Database filter returns string not object Signed-off-by: Grant Seward <grant@stemma.ai> * Added comma to fix syntax text Signed-off-by: Grant Seward <grant@stemma.ai> * docs: update databuilder directory name after deprecating databuilder submodule (amundsen-io#1106) Signed-off-by: Marcin Mazurek <marcin@mazurek.pro> * docs: fix some broken links (amundsen-io#1125) Signed-off-by: Dorian Johnson <2020@dorianj.net> * update ModePaginatedRestApiQuery default parameterrs (amundsen-io#1126) Signed-off-by: Junda Yang <youngyjd@gmail.com> * Fix: Make BigQuery extractors support Relational Metadata store (amundsen-io#1109) * Modify Watermark extractor to support relational metadata store Signed-off-by: Sahithi Velma <sahithiv@wepay.com> * Modify BigQuery Usage extractor to support relational metadata store Signed-off-by: Sahithi Velma <sahithiv@wepay.com> * Modify BigQuery Usage extractor to only count usage of tables present in the project_id_key Signed-off-by: Sahithi Velma <sahithiv@wepay.com> Co-authored-by: Sahithi Velma <sahithiv@wepay.com> * feat: Pandas-Profiling TableColumnStats Extractor (amundsen-io#1105) introduces pandas-profiling based extractor for table column stats * feat: support skipping configured Mode spaces (amundsen-io#1129) * bump up databuilder version to 4.4.1 (amundsen-io#1130) * fix typo aws_secret_access_key in neptune csv publisher (amundsen-io#1134) Signed-off-by: iamtodor <todor.ilya@gmail.com> * fix: search_table API swagger file bug fix (amundsen-io#1120) * search table swagger file bug fix Signed-off-by: nishant_cimpress <nishant.sharma@cimpress.com> * removed comment Signed-off-by: nishant_cimpress <nishant.sharma@cimpress.com> Co-authored-by: nishant_cimpress <nishant.sharma@cimpress.com> * feat: Atlas Lineage support (amundsen-io#1103) introduces support for lineage in atlas metadata proxy * fix: atlas proxy fix (amundsen-io#1139) Signed-off-by: dechoma <dominik.choma@gmail.com> * feat: use chart_names in dashboard basic search (amundsen-io#1140) Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * fix: pytest setup.cfg section fix (amundsen-io#1144) Signed-off-by: Jakub Nowacki <j.s.nowacki@gmail.com> * chore: remove a comment that conflicts with implementation (amundsen-io#1154) Signed-off-by: Tero Paananen <tpaananen@bloomberg.net> * feat: Common query models (amundsen-io#1155) * Added join and where models for how tables are joined / filtered with sql Signed-off-by: Grant Seward <grant@stemma.ai> * removed addl space Signed-off-by: Grant Seward <grant@stemma.ai> * version bump Signed-off-by: Grant Seward <grant@stemma.ai> * feat: Configuration option to init custom routes (amundsen-io#1160) * configuration option to init custom routes Signed-off-by: verdan <verdan.mahmood@gmail.com> * Fixes isort Signed-off-by: verdan <verdan.mahmood@gmail.com> * :sigh: really fixes isort Signed-off-by: verdan <verdan.mahmood@gmail.com> * feat: Search service adding suport for AWS Elasticsearch (amundsen-io#1141) Signed-off-by: Jakub Nowacki <j.s.nowacki@gmail.com> * Fix installation link (amundsen-io#1159) The link was broken Signed-off-by: Fokko Driesprong <fokko@datafold.com> * fix: 1157 issude - metadata sql alchemy for iodc component (amundsen-io#1169) Signed-off-by: iamtodor <todor.ilya@gmail.com> * Helm service versions moved up to latest ones (amundsen-io#1165) Signed-off-by: Jakub Nowacki <j.s.nowacki@gmail.com> * Fix doc links in README.md (amundsen-io#1164) Just a quick driveby to fix a few doc links that still point to old locations. Signed-off-by: James Davidheiser <jamesdavidheiser@asana.com> * fix: aws_config (amundsen-io#1167) Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * fix: add optional list to atlas_search_extractor (amundsen-io#1180) Signed-off-by: dechoma <dominik.choma@gmail.com> * feat: introduce atlas serializable for dashboards (amundsen-io#1138) Signed-off-by: dechoma <dominik.choma@gmail.com> * build(deps): bump amundsenrds from `589be11` to `4509bb0` (amundsen-io#1174) Bumps [amundsenrds](https://github.com/amundsen-io/amundsenrds) from `589be11` to `4509bb0`. - [Release notes](https://github.com/amundsen-io/amundsenrds/releases) - [Commits](amundsen-io/amundsenrds@589be11...4509bb0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * chore: bump up amundsen_common to 0.13.0 (amundsen-io#1183) Signed-off-by: dechoma <dominik.choma@gmail.com> * fix: add amundsen-common requirement (amundsen-io#1184) Signed-off-by: dechoma <dominik.choma@gmail.com> * feat: support mysql in metadata service (amundsen-io#1182) * support metadata service for mysql Signed-off-by: xuans <xuan_shen@outlook.com> * update doc Signed-off-by: xuans <xuan_shen@outlook.com> * fixed some typo in doc Signed-off-by: xuans <xuan_shen@outlook.com> * Add configurable cli registration Signed-off-by: xuans <xuan_shen@outlook.com> * test: Increase test coverage for atlas proxy (amundsen-io#1173) Signed-off-by: sinkuladis <sink.vlad@gmail.com> * Fix broken anchor link in readme (amundsen-io#1193) the section anchor for troubleshoot section is broken, I added the correct anchor. Signed-off-by: qiman-wang <wangqiman0111@gmail.com> * chore: update requirement file in metadata (amundsen-io#1194) * chore: update requirement file in metadata Signed-off-by: feng-tao <fengtao04@gmail.com> * chore: update CI Signed-off-by: feng-tao <fengtao04@gmail.com> * update version Signed-off-by: feng-tao <fengtao04@gmail.com> * Docs: add AWS Neptune to metadata*s Readme (amundsen-io#1197) * add AWS Neptune to metadata*s Readme Signed-off-by: iamtodor <todor.ilya@gmail.com> * Update README.md Co-authored-by: Tao Feng <tfeng@apache.org> * feat: Add databuilder models for Feature (amundsen-io#1201) * [feat] Add databuilder models for Feature Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * add feature model docs Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * fix dashboard owner test Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * lint failures Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * docstring improvements Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * bump version Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * feat: Generic Usage Extractor (amundsen-io#1199) Signed-off-by: Allison Doami <adoami@chanzuckerberg.com> * add information about default ES indexes to search Readme (amundsen-io#1198) Signed-off-by: iamtodor <todor.ilya@gmail.com> * chore: add myself as codeowner for other services (amundsen-io#1204) Signed-off-by: Dorian Johnson <2020@dorianj.net> * Add backwards compatible support for Jira cloud/hosted. (amundsen-io#1207) Signed-off-by: BB <boyan@typed.wtf> * refactor: shared dependencies unification (amundsen-io#1163) * unify_deps | 🎉 Initial commit. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | ♻️ Refactoring code. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | 🐛 Fixing a bug. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | 🐛 Fixing a bug. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | 🐛 Fixing a bug. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | 🚨 Removing linter warnings. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | 🚨 Removing linter warnings. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | 🚨 Removing linter warnings. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | ✅ Adding tests. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | ⬆️ Upgrading dependencies. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | 🐛 Fixing a bug. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | ✨ Introducing new features. (run tests when reqs change) Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | 🐛 Fixing a bug. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | 🐛 Fixing a bug. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | ♻️ Refactoring code. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | 💡 Documenting source code. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | 📝 Writing docs. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | 💄 Updating the UI and style files. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | 🐛 Fixing a bug. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | ⬆️ Upgrading dependencies. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | ♻️ Refactoring code. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | 🐛 Fixing a bug. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | 🐛 Fixing a bug. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | 💡 Documenting source code. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | 🚨 Removing linter warnings. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | 👌 Updating code due to code review changes. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | 🐛 Fixing a bug. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | 🐛 Fixing a bug. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | 🐛 Fixing a bug. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | 🐛 Fixing a bug. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | 🎉 Initial commit. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> * unify_deps | 🐛 Fixing a bug. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com> Co-authored-by: Dorian Johnson <2020@dorianj.net> * fix: update sharded_table filter in BigQuery extractor (amundsen-io#1209) * updated shared-table validator Signed-off-by: xuans <xuan_shen@outlook.com> * renaming Signed-off-by: xuans <xuan_shen@outlook.com> * fix mypy Signed-off-by: xuans <xuan_shen@outlook.com> * fix lint Signed-off-by: xuans <xuan_shen@outlook.com> * fix: Add forgotten init file to databuilder/models/feature module (amundsen-io#1211) * add init file to feature module Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * loosen mypy annotation Signed-off-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> * fix: bug amundsen-io#1213 relates to AWS creds Neptune (amundsen-io#1214) * fix bug amundsen-io#1213 relates to AWS creds Neptune Signed-off-by: iamtodor <todor.ilya@gmail.com> * code clean up Signed-off-by: iamtodor <todor.ilya@gmail.com> * fix - Update README to GenericUsageExtractor (amundsen-io#1217) Signed-off-by: Allison Doami <adoami@chanzuckerberg.com> * fix db key constraints (amundsen-io#1216) Signed-off-by: Junda Yang <jyang@brex.com> * install stemma reqs Signed-off-by: Grant Seward <grant@stemma.ai> * requirement version pin Signed-off-by: Grant Seward <grant@stemma.ai> * req update again Signed-off-by: Grant Seward <grant@stemma.ai> * frontend reqs Signed-off-by: Grant Seward <grant@stemma.ai> * Applied to metadata and search Signed-off-by: Grant Seward <grant@stemma.ai> * added responses Signed-off-by: Grant Seward <grant@stemma.ai> * fstring fix Signed-off-by: Grant Seward <grant@stemma.ai> Co-authored-by: mgorsk1 <gorskimariusz13@gmail.com> Co-authored-by: Verdan Mahmood <verdan.mahmood@gmail.com> Co-authored-by: Allison Suarez Miranda <22477579+allisonsuarez@users.noreply.github.com> Co-authored-by: dechoma <dominik.choma@gmail.com> Co-authored-by: KevinDukelow5 <Kevin_dukelow@colpal.com> Co-authored-by: Junda Yang <youngyjd@gmail.com> Co-authored-by: Adam Boscarino <aboscarino@devoted.com> Co-authored-by: Dorian Johnson <2020@dorianj.net> Co-authored-by: Marcin Mazurek <marcin@mazurek.pro> Co-authored-by: Sahithi Reddy Velma <46659774+sahithi03@users.noreply.github.com> Co-authored-by: Sahithi Velma <sahithiv@wepay.com> Co-authored-by: iamtodor <todor.ilya@gmail.com> Co-authored-by: Nishant Sharma <nishantmaharishi@gmail.com> Co-authored-by: nishant_cimpress <nishant.sharma@cimpress.com> Co-authored-by: Jakub Nowacki <j.s.nowacki@gmail.com> Co-authored-by: gorbachev <tpp+github@iki.fi> Co-authored-by: Fokko Driesprong <fokko@driesprong.frl> Co-authored-by: James Davidheiser <jdavidheiser@users.noreply.github.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Xuan <65048031+crazy-2020@users.noreply.github.com> Co-authored-by: sinkuladis <sink.vlad@gmail.com> Co-authored-by: QimanWang <wangqiman0111@gmail.com> Co-authored-by: Tao Feng <fengtao04@gmail.com> Co-authored-by: Tao Feng <tfeng@apache.org> Co-authored-by: Dmitriy Kunitskiy <dkunitskiy@lyft.com> Co-authored-by: Allison Doami <adoami@chanzuckerberg.com> Co-authored-by: Boyan Bonev <bbsbb@users.noreply.github.com> Co-authored-by: Junda Yang <jyang@brex.com>
introduces support for lineage in atlas metadata proxy
introduces support for lineage in atlas metadata proxy
Summary of Changes
Introduces support for lineage retrieval in Atlas Proxy.
Tests
Documentation
CheckList
Make sure you have checked all steps below to ensure a timely review.