Freature/atlas serializable #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgorsk1
reviewed
May 18, 2021
|
|
||
| class FsAtlasCSVLoader(Loader): | ||
| """ | ||
| Write node and relationship CSV file(s) that can be consumed by |
| """ | ||
| Write node and relationship CSV file(s) that can be consumed by | ||
| AtlasCsvPublisher. | ||
| It assumes that the record it consumes is instance of AtlasCsvSerializable |
There was a problem hiding this comment.
shouldn't it just be AtlasSerializable?
|
|
||
|
|
||
|
|
||
| def _get_neo4j_suffix_value(value: Any) -> str: |
| # Directory should be deleted after publish is finished | ||
| Job.closer.register(_delete_dir) | ||
|
|
||
| def load(self, csv_serializable: AtlasSerializable) -> None: |
|
|
||
| from collections import namedtuple | ||
|
|
||
| AtlasEntity = namedtuple( |
There was a problem hiding this comment.
is it possible to enforce presence of qualifiedName within attributes?
| super(AtlasCSVPublisher, self).__init__() | ||
|
|
||
| def init(self, conf: ConfigTree) -> None: | ||
| self._atlas_client = AtlasClient('http://localhost:21000', ('admin', 'admin')) |
There was a problem hiding this comment.
this one can be pretty much copied from atlas_search_data_extractor.py
| TYPE_NAME: entity.typeName | ||
| } | ||
| for key, value in entity.attributes.items(): | ||
| key_suffix = '-elo' |
mgorsk1
reviewed
May 18, 2021
| from databuilder.models.atlas_entity import AtlasEntity | ||
| from databuilder.models.atlas_relationship import AtlasRelationship | ||
|
|
||
| GUID = 'guid' |
There was a problem hiding this comment.
idea: amundsen-io#1103 introduces atlas_utils.py in amundsen_common which could be reused here
Signed-off-by: DOMINIK CHOMA <dominik.choma@ing.com>
Signed-off-by: DOMINIK CHOMA <dominik.choma@ing.com>
Signed-off-by: DOMINIK CHOMA <dominik.choma@ing.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Tests
Documentation
CheckList
Make sure you have checked all steps below to ensure a timely review.