-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add typescript declarations formats #542
Conversation
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.8)
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.8)
amzn#513) Bumps [node-notifier](https://github.com/mikaelbr/node-notifier) from 8.0.0 to 8.0.1. - [Release notes](https://github.com/mikaelbr/node-notifier/releases) - [Changelog](https://github.com/mikaelbr/node-notifier/blob/v8.0.1/CHANGELOG.md) - [Commits](mikaelbr/node-notifier@v8.0.0...v8.0.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
feat(formats): add typescript/module-declarations formats for .d.ts
docs(formats): add typescript/module-declarations docs
@chazzmoney Could you take a look at it? This is also a duplicate with extension of #467 as the PR seems dead. |
Thanks for this @Tiamanti Can you do it off of branch 3.0 instead of main? I know its confusing at the moment, but we won't be merging much of anything into main anymore besides documentation about 3.0. It should also get you on the right checks. |
the changes look good to me, though my typescript knowledge is not as strong as yours I'm sure |
Hi @Tiamanti Just wanted to see if you were working on a 3.0 branch version of this? I was assuming so because of the thumbs up emoji you sent, but wanted to clarify. Thanks! |
Hi @Tiamanti I switched it to 3.0 to clarify that is what you should be working off of / that is where it will be merged when ready. |
*Issue #425
Description of changes:
feat(formats): add typescript/es6-declarations formats for .d.ts
feat(formats): add typescript/module-declarations formats for .d.ts
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.