DMA Scatter-Gather Testbench #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastmaier
requested changes
Oct 31, 2023
|
@podgori can you check the conflict and resolve the comments? |
IstvanZsSzekely
requested changes
Aug 7, 2024
|
I think I have addressed most of the requested changes, this TB is ready to be merged. |
gastmaier
approved these changes
Aug 23, 2024
IstvanZsSzekely
requested changes
Aug 23, 2024
dma_sg/tests/test_program_1d.sv
Outdated
Comment on lines
77
to
78
| `TH.`DEVICE_CLK.inst.IF.start_clock(); | ||
| env.sys_reset(); |
There was a problem hiding this comment.
Starting the clocks and resetting the system should be done before probing (accessing) the DMA cores
dma_sg/tests/test_program_2d.sv
Outdated
Comment on lines
77
to
78
| `TH.`DEVICE_CLK.inst.IF.start_clock(); | ||
| env.sys_reset(); |
There was a problem hiding this comment.
Same as previously
Comment on lines
77
to
78
| `TH.`DEVICE_CLK.inst.IF.start_clock(); | ||
| env.sys_reset(); |
There was a problem hiding this comment.
Same as previously
Signed-off-by: Ionut Podgoreanu <ionut.podgoreanu@analog.com>
IstvanZsSzekely
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a testbench for the Scatter-Gather feature which tests the following: