Merge pull request #452 from anatawa12/pb-for-parameters-removed

fix: PB for Animator Parameter disappears
anatawa12 · Sep 11, 2023 · 71e80b6 · 71e80b6
2 parents 16d879d + c4d4dc6
commit 71e80b6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/CHANGELOG-PRERELEASE.md b/CHANGELOG-PRERELEASE.md
@@ -17,6 +17,7 @@ The format is based on [Keep a Changelog].
 
 ### Fixed
 - MergeBone will break Normal and Tangent `#448`
+- PhysBone for Animator Parameter disappears `#452`
 
 ### Security
 

diff --git a/Editor/Processors/TraceAndOptimize/ComponentDependencyCollector.cs b/Editor/Processors/TraceAndOptimize/ComponentDependencyCollector.cs
@@ -496,6 +496,11 @@ void CollectTransforms(Transform bone)
  // in PB, PB Colliders work only if Colliders are enabled
  foreach (var physBoneCollider in physBone.colliders)
  deps.AddActiveDependency(physBoneCollider, true);
+
+ // If parameter is not empty, the PB can be required for Animator Parameter so it's Entrypoint Component
+ // https://github.com/anatawa12/AvatarOptimizer/issues/450
+ if (!string.IsNullOrEmpty(physBone.parameter))
+ deps.EntrypointComponent = true;
  });
  AddParser<VRCPhysBoneColliderBase>((collector, deps, component) =>
  {