Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attestation with a private key #1465

Closed
TomiOhl opened this issue Jan 17, 2023 · 3 comments · Fixed by #1502
Closed

Attestation with a private key #1465

TomiOhl opened this issue Jan 17, 2023 · 3 comments · Fixed by #1502
Assignees
Labels
bug Something isn't working

Comments

@TomiOhl
Copy link

TomiOhl commented Jan 17, 2023

What happened:
The readme still has the steps using the now removed --key flag.
Relevant parts:

What you expected to happen:
The readme should be updated to reflect the breaking changes between v0.65.0 and v0.66.0. Trying to run the given command results in the following error: error during command execution: unknown flag: --key. I'd appreciate up-to-date steps.

Anything else we need to know?:
If the problem is on my side and the readme is correct, let me know and I'll provide more relevant feedback.

@TomiOhl TomiOhl added the bug Something isn't working label Jan 17, 2023
@ReDemoNBR
Copy link

I have similar issue in my CI environment that has the key stored in the secrets.
I'm looking for updated steps for the attestation.

If needed, I can be available to help

@tgerla
Copy link
Contributor

tgerla commented Jan 18, 2023

Hi @TomiOhl and @ReDemoNBR, thanks for catching this. We will have an updated README and a new way to specify a private key in the next release of Syft. Stay tuned--for the time being you can go back to Syft 0.66.0. There's some additional information about the change here: #1442

Hope this helps and sorry for the trouble!

@spiffcs
Copy link
Contributor

spiffcs commented Jan 26, 2023

@TomiOhl I've merged a new change that's unreleased but on the tip of main. Let me know if this is still behaving incorrectly to your expectations.

I can also reopen the issue or file a new one if there are other asks surrounding this workflow. Thanks again!

Tested with:
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants