-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update attestation code to remove library dependencies and shellout for keyless flow #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Benchmark Test ResultsBenchmark results from the latest changes vs base branch
|
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
spiffcs
commented
Jan 9, 2023
spiffcs
commented
Jan 9, 2023
spiffcs
commented
Jan 9, 2023
spiffcs
commented
Jan 9, 2023
spiffcs
commented
Jan 9, 2023
spiffcs
commented
Jan 9, 2023
spiffcs
commented
Jan 9, 2023
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
cff79a9
to
54415a7
Compare
spiffcs
commented
Jan 11, 2023
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
wagoodman
reviewed
Jan 11, 2023
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
wagoodman
approved these changes
Jan 12, 2023
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
This was referenced Jan 26, 2023
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
…out for keyless flow (anchore#1442) Co-authored-by: Alex Goodman <alex.goodman@anchore.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When importing
cosign
library dependencies for attestation support the syft binary grows from 29MB -> 63MB.This PR shrinks the final binary size back to 29MB by incorporating a shell out alternative for the keyless flow. A second PR will follow that implements custom PKI provided by the user.
Fixes
syft attest
to use locally available cosign binarydevice
flowcustom
predicate format for sbom attestation: see predicate typeCOSIGN_EXPERIMENTAL=1
will need to interact with the provided URL in the output of the command to create the t-log entry for rekorCurrent Example Workflow
Currently, users of syft can use cosign to attest sbom outputs by running the following two commands:
Note in the above example, the image
caphill4/test:latest
should be an image the user has write permissions for uploaded in some image registry.New Syft Attest
Note: off-screen is the device flow of using the generated URL to provide keyless credentials for the attestation
The same verification flow listed above can be used to verify the same attestation

TODO:
Signed-off-by: Christopher Phillips christopher.phillips@anchore.com