1465 attestation with private key #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark Test ResultsBenchmark results from the latest changes vs base branch |
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
spiffcs
force-pushed
the
1465-attestation-with-private-key
branch
from
f5797e3 to
81f8fed
Compare
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
kzantow
approved these changes
Jan 26, 2023
| } | ||
|
|
||
| func (cfg attest) loadDefaultValues(v *viper.Viper) { | ||
| v.SetDefault("attest.key", "") |
There was a problem hiding this comment.
I think this is already set because of the v.BindPFlag("attest.key", flags.Lookup("key")) earlier
There was a problem hiding this comment.
Nice! I removed it and didn't see any change. I would like to keep this though as the default that is called even if v.BindPFlag("attest.key", flags.Lookup("key")) is not invoked during another command.
I don't think v.BindPFlag("attest.key", flags.Lookup("key")) is called during other non attest command executions and having the config set explicit defaults overall seems cleaner than implicitly blank strings if nothing is called.
This was referenced Jan 30, 2023
This was referenced Jan 31, 2023
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
1465 attestation with private key (anchore#1502) Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return PKI options to original documented state
Closes #1465
Users can now add a --key <KEY_PATH> option to the syft attest command. This option will be passed to the shell out command introduced #1442
Users can set the password for the key by using the environment variable
SYFT_ATTEST_PASSWORDPrevious versions of syft offered an interactive TUI for typing the password. Because of the nature of the shellout command this option is no longer available
To test:
cosign generate-key-pairgo run ./cmd/syft/main.go attest --key cosign.key <IMAGE_WITH_WRITE_ACCESS>