fix: improve determinism in java archive identification #3085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Zantow <kzantow@gmail.com>
spiffcs
approved these changes
Jul 30, 2024
…ava-pom-properties-order
Signed-off-by: Keith Zantow <kzantow@gmail.com>
westonsteimel
added a commit
that referenced
this pull request
Aug 9, 2024
Updates the purl generation tests now that syft has better deterministic results per #3085 Signed-off-by: Weston Steimel <commits@weston.slmail.me>
westonsteimel
added a commit
that referenced
this pull request
Aug 9, 2024
Updates the purl generation tests now that syft has more deterministic results per #3085 Signed-off-by: Weston Steimel <commits@weston.slmail.me>
westonsteimel
added a commit
that referenced
this pull request
Aug 9, 2024
Updates the purl generation tests now that syft has more deterministic results per #3085 Signed-off-by: Weston Steimel <commits@weston.slmail.me>
westonsteimel
added a commit
that referenced
this pull request
Aug 9, 2024
Updates the purl generation tests now that syft has more deterministic results per #3085 Signed-off-by: Weston Steimel <commits@weston.slmail.me>
westonsteimel
added a commit
that referenced
this pull request
Aug 9, 2024
Updates the purl generation tests now that syft has more deterministic results per #3085 Signed-off-by: Weston Steimel <commits@weston.slmail.me>
westonsteimel
added a commit
that referenced
this pull request
Aug 9, 2024
ensures correct package url generation for more java packages now that syft has more deterministic results per #3085 Signed-off-by: Weston Steimel <commits@weston.slmail.me>
westonsteimel
added a commit
that referenced
this pull request
Aug 9, 2024
ensures correct package url generation for more java packages now that syft has more deterministic results per #3085 Signed-off-by: Weston Steimel <commits@weston.slmail.me>
westonsteimel
added a commit
that referenced
this pull request
Aug 9, 2024
ensures correct package url generation for more java packages now that syft has more deterministic results per #3085 Signed-off-by: Weston Steimel <commits@weston.slmail.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a case where Syft is generating Java packages in a nondeterministic manner when there are multiple
pom.propertiesthat it considers to be "matching".This PR is only to make a deterministic SBOM, and we can iterate on this later to further improve identification, such as: #3054
Partially fixes: #2967