Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add get_pid method to PTY struct #6

Merged
merged 1 commit into from
Jan 11, 2022
Merged

PR: Add get_pid method to PTY struct #6

merged 1 commit into from
Jan 11, 2022

Conversation

andfoy
Copy link
Owner

@andfoy andfoy commented Jan 11, 2022

No description provided.

@andfoy andfoy added this to the v0.2.0 milestone Jan 11, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #6 (22521bf) into main (fd6be6c) will increase coverage by 0.45%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   45.16%   45.62%   +0.45%     
==========================================
  Files           9        9              
  Lines        1676     1690      +14     
==========================================
+ Hits          757      771      +14     
  Misses        919      919              
Flag Coverage Δ
unittests 45.62% <100.00%> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pty.rs 67.08% <100.00%> (+1.29%) ⬆️
src/pty/base.rs 73.61% <100.00%> (+0.37%) ⬆️
src/pty/conpty/pty_impl.rs 71.62% <100.00%> (+0.29%) ⬆️
src/pty/winpty/pty_impl.rs 79.16% <100.00%> (+0.37%) ⬆️
tests/conpty.rs 50.68% <100.00%> (+0.34%) ⬆️
tests/winpty.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd6be6c...22521bf. Read the comment docs.

@andfoy andfoy merged commit f170946 into main Jan 11, 2022
@andfoy andfoy deleted the get_pid branch January 11, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants