Temporary PR corresponding to OpenFAST pr 2014 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- RotGetOP - Init_Jacobian_y - Init_Jacobian_u - Perturb_u Perturbing of extended inputs not yet completed
Indenting was a bit wonky in places
I think it is more readable this way (others may rightfully disagree)
Also comment out the call to IfW_UpdateStates (routine removed)
Swap ordering from - AD14 - AD15 - ExtLoads - InflowWind - SuperController - SeaState to - AD14 - InflowWind - SeaState - AD15 - ExtLoads - SuperController
Also modify call order in the ADI library
Not sure aero settings are correct, but should give a reasonable estimate if things are working right or not. So far not. - original results generated by 3.5.2
Aero still not working. Nacelle and Hub causing segfaults from fAST_Lin
Very good agreement: * MAP has mode at 0.057 Hz * MD has 3 modes at ~0.054 Hz
The start index for the BD motion was set to start at the BD reaction forces, not at the start of the motions. So reaction loads were getting mapped as motions, and all motion info in dUdy was shifted.
…/AD15_IfW_Linearization
If a Failed() calls a Cleanup(), and Cleanup() tries to handle errors about deallocations with a call to Failed(), then Failed() becomes recursive. Also a few minor error handling and MHK check changes
- increase `atol` for Jacobian matrix comparisons - tighten limits on frequency/damping comparisons - Also update a couple of cases with results from GH prior to loosening tolerances.
…AD15_IfW_Linearization
…AD15_IfW_Linearization Some regression tests need updating
…15_IfW_Linearization
added -j1 flag so that this test always runs sequential. Otherwise the 5MW_OC3Mnpl_DLL_WTurb_WavesIrr_Restart may kick off before 5MW_OC3Mnpl_DLL_WTurb_WavesIrr has any input files generated
This was removed at some point during the linearization work, which broke all AD14 cases.
Added values from IfW/FlowField: HWindSpeed/PLexp/PropagationDir
andrew-platt
force-pushed
the
f/AD15_IfW_Linearization
branch
from
e83495e
to
8d18d2f
Compare
|
Not actually merging this. It was just for comparison. |
andrew-platt
pushed a commit
that referenced
this pull request
May 10, 2024
UA driver bug fix: sim mod 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary PR for comparing exactly what changes in PR OpenFAST#2014 compared to OpenFAST#1882