Linearization with AD15 and IfW #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- RotGetOP - Init_Jacobian_y - Init_Jacobian_u - Perturb_u Perturbing of extended inputs not yet completed
Indenting was a bit wonky in places
I think it is more readable this way (others may rightfully disagree)
Also comment out the call to IfW_UpdateStates (routine removed)
andrew-platt
force-pushed
the
f/AD15_IfW_Linearization
branch
from
46a0059
to
617c39e
Compare
Swap ordering from - AD14 - AD15 - ExtLoads - InflowWind - SuperController - SeaState to - AD14 - InflowWind - SeaState - AD15 - ExtLoads - SuperController
Also modify call order in the ADI library
andrew-platt
force-pushed
the
f/AD15_IfW_Linearization
branch
from
85365c4
to
ea3a2c1
Compare
Not sure aero settings are correct, but should give a reasonable estimate if things are working right or not. So far not. - original results generated by 3.5.2
andrew-platt
force-pushed
the
f/AD15_IfW_Linearization
branch
from
f978097
to
89d511f
Compare
…AD15_IfW_Linearization Some regression tests need updating
…15_IfW_Linearization
added -j1 flag so that this test always runs sequential. Otherwise the 5MW_OC3Mnpl_DLL_WTurb_WavesIrr_Restart may kick off before 5MW_OC3Mnpl_DLL_WTurb_WavesIrr has any input files generated
This was removed at some point during the linearization work, which broke all AD14 cases.
Added values from IfW/FlowField: HWindSpeed/PLexp/PropagationDir
andrew-platt
force-pushed
the
f/AD15_IfW_Linearization
branch
2 times, most recently
from
d0c2301
to
6c757fc
Compare
andrew-platt
force-pushed
the
f/AD15_IfW_Linearization
branch
from
6c757fc
to
bd880b0
Compare
This was referenced Apr 30, 2024
|
See andrew-platt#23 for a temporary PR for comparing what changes in this PR relative to #1882. |
andrew-platt
force-pushed
the
f/AD15_IfW_Linearization
branch
from
e83495e
to
8d18d2f
Compare
deslaughter
approved these changes
May 2, 2024
…AD15_IfW_Linearization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready for merging.
Feature or improvement description
When InflowWind was converted to use pointers, significant changes were required to AeroDyn to support this with linearization (InflowWind outputs are no longer inputs to AeroDyn). This is the second of 3 PR's to address this.
Related issue, if one exists
PR #1882 is the first PR in the sequence.
Impacted areas of the software
Linearization in the following modules is affected:
Additional supporting information
Test results, if applicable
5MW_Land_BD_Linear_Aero- same results, different matrix size. Extended outputs from IfW to AD155MW_Land_BD_Linear- slight change in results5MW_Land_Linear_Aero- same results, different matrix size. Extended outputs from IfW to AD155MW_OC3Spar_Linear- same results, different matrix size. Extended outputs from SS to HD5MW_OC4Semi_Linear- same results, different matrix size. Extended outputs from SS to HD5MW_OC4Semi_MD_Linear- same results, different matrix size. Extended outputs from SS to HDFake5MW_AeroLin_B1_UA4_DBEMT3- same results asdev-unstable-pointersbranch, different matrix size. Extended outputs from IfW to AD15.Fake5MW_AeroLin_B3_UA6- same results asdev-unstable-pointersbranch, different matrix size. Extended outputs from IfW to AD15.Ideal_Beam_Fixed_Free_Linear- same results, different matrix sizeIdeal_Beam_Free_Free_Linear- same results, different matrix sizeNote: This branch will be rebased soon to resolve conflicts and simplify comparisons.