Fix WASAPI resampling when the sample rate significantly differs from the mix format #194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My application is decoding incoming audio at a fixed 48 KHz sample rate and I'm depending on WASAPI resampling to handle conversion to the mix format. Right now, libsoundio is using
AUDCLNT_STREAMFLAGS_RATEADJUST
andIAudioClockAdjustment::SetSampleRate()
to handle sample rates that differ from the native mix format.However, when setting my mix format in the Sound Control Panel to 16-bit, 192 KHz,
SetSampleRate()
fails withE_INVALIDARG
meaning "The sample rate is out of the range for the Audio Processing Object." according to MSDN. The amount of sample rate adjustment available usingSetSampleRate()
appears to be limited.It seems that what we really want here is
AUDCLNT_STREAMFLAGS_AUTOCONVERTPCM
which automatically handles sample rate conversion to the mix format. Using this flag fixes the 48 KHz -> 192 KHz resampling case.To reproduce:
soundio_outstream_open()
fails withSoundIoErrorOpeningDevice