Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing WASAPI macros for resampling #198

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Conversation

Crunkle
Copy link
Contributor

@Crunkle Crunkle commented Dec 6, 2018

The macros needed to fix #194 are not defined by the MinGW headers (see here).

@cgutman
Copy link
Contributor

cgutman commented Dec 6, 2018

Have you tried getting them added to MinGW upstream? I think that's the best approach here, since they are officially documented flags.

@Crunkle
Copy link
Contributor Author

Crunkle commented Dec 7, 2018

For sure, I will submit a merge when possible, so feel free to reject this if we're out of scope.

The rationale behind adding this here is based on the fact that the majority of systems will continue using outdated headers for the time being (either from package managers or MXE). It seemed a shame to cut off all older versions and complicate the build process simply due to two macros.

@cgutman
Copy link
Contributor

cgutman commented Dec 7, 2018

In that case, I think it's fine to do both, but we should definitely get MinGW fixed so we don't have to carry these defines forever.

@andrewrk andrewrk merged commit e96dcd5 into andrewrk:master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants