Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Replace YAML with HTML in F-Droid fastlane summary #873

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

fmeum
Copy link
Member

@fmeum fmeum commented Jun 22, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

📜 Description

When using the fastlane structure, F-Droid requires summaries to be marked up with HTML instead of YAML.

💡 Motivation and Context

https://gitlab.com/fdroid/fdroiddata/-/merge_requests/6844#note_365752950

💚 How did you test it?

📝 Checklist

  • I formatted the code with the IDE's reformat action (Ctrl + Shift + L/Cmd + Shift + L)
  • I reviewed submitted code
  • I added a CHANGELOG entry if applicable

🔮 Next steps

📸 Screenshots / GIFs

When using the fastlane structure, F-Droid requires summaries to be marked up with HTML instead of YAML: https://gitlab.com/fdroid/fdroiddata/-/merge_requests/6844#note_365752950.
Copy link
Member

@msfjarvis msfjarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fastest review ever?

@fmeum fmeum merged commit 4ebd41a into master Jun 22, 2020
@fmeum fmeum deleted the bug/fdroid_description branch June 22, 2020 16:01
@fmeum
Copy link
Member Author

fmeum commented Jun 22, 2020

Fastest review ever?

I think so, it's almost as if you were CI ;-)

fmeum pushed a commit that referenced this pull request Jun 22, 2020
Missed the linebreaks in #873.
@fmeum fmeum mentioned this pull request Jun 22, 2020
8 tasks
msfjarvis pushed a commit that referenced this pull request Jun 22, 2020
msfjarvis added a commit that referenced this pull request Jun 27, 2020
* develop: (24 commits)
  UI fixups (#892)
  Update Public Suffix List data (#888)
  Use remembered credential even if it is empty (#880)
  Reset SSH passphrase after SSH key import (#885)
  Prevent cached passwords from being wiped (#884)
  build: uprev all dependencies (#882)
  github: update actions for updated branching logic
  Use a custom sshj config (#878)
  Remove API 30 from pull request test matrix (#879)
  Add Google Play/F-Droid badges to the README (#877)
  Retire Android Arsenal badge (#876)
  Add paragraphs to F-Droid summary (#874)
  Replace YAML with HTML in F-Droid fastlane summary (#873)
  Add relnotes for #871 (#872)
  Add org.gnu.icecat as a trusted multi-origin browser (#871)
  README: re-add F-Droid (#870)
  build: prepare next development version
  build: bump version to 1.9.0
  Prepare release 1.9.0
  PasswordCreationActivity: properly guard rename code
  ...

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants