This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
Prevent cached passwords from being wiped #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msfjarvis
approved these changes
Jun 26, 2020
msfjarvis
added a commit
that referenced
this pull request
Jun 27, 2020
* develop: (24 commits) UI fixups (#892) Update Public Suffix List data (#888) Use remembered credential even if it is empty (#880) Reset SSH passphrase after SSH key import (#885) Prevent cached passwords from being wiped (#884) build: uprev all dependencies (#882) github: update actions for updated branching logic Use a custom sshj config (#878) Remove API 30 from pull request test matrix (#879) Add Google Play/F-Droid badges to the README (#877) Retire Android Arsenal badge (#876) Add paragraphs to F-Droid summary (#874) Replace YAML with HTML in F-Droid fastlane summary (#873) Add relnotes for #871 (#872) Add org.gnu.icecat as a trusted multi-origin browser (#871) README: re-add F-Droid (#870) build: prepare next development version build: bump version to 1.9.0 Prepare release 1.9.0 PasswordCreationActivity: properly guard rename code ... Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
msfjarvis
added a commit
that referenced
this pull request
Jul 1, 2020
* develop: Scroll to files and enter folders when created (#909) Run a treewide reformat (#908) Improve how secrets and stored and used (#907) Improve and refactor Autofill heuristics (#905) Use PreferenceKeys file to manage SharedPreferences keys. (#891) Bump version Prepare release 1.9.2 update changelog Workaround to prevent crash on first run (#898) build: bump version Prepare release 1.9.1 Backport Actions fixes (#894) Remove API 30 from pull request test matrix (#879) CHANGELOG: reword to better clarify fixes Prevent cached passwords from being wiped (#884) Use remembered credential even if it is empty (#880) Reset SSH passphrase after SSH key import (#885) Add relnotes for #871 (#872) Add org.gnu.icecat as a trusted multi-origin browser (#871)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Clone all passphrases returned from
reqPasswordto prevent the cached one from being wiped.Note that since we are getting our passphrases from an EditText's
textproperty, securely wiping all sensitive data is impossible anyway.💡 Motivation and Context
Should fix the second issue brought up in #875.
💚 How did you test it?
It resolves #875 (comment) for me but @Schueni1 should confirm that it does.
📝 Checklist
🔮 Next steps
📸 Screenshots / GIFs