Clearing package data also revokes development permissions on API < 23 #2181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the behavior on API 23 and newer.
consp1racy
force-pushed
the
ep/revokePermissionsCompat
branch
from
61d02c9
to
9f88505
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the behavior on API 23 and newer.
Background
We have a custom
androidTestUtilAPK that backportsUiConnection.executeShellCommandto Kitkat. It's AOSP-signed so it works in AVD, which has to be enough.We use it to grant a library under test
android.permission.WRITE_SECURE_SETTINGS. We also need to clean that up in the test.Given that the instrumentation package and target package are the same, removing permission kills our instrumentation process. The solution is to revoke permissions from the orchestrator when
testInstrumentationRunnerArguments["clearPackageData"] = "true".