Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jetcaster] Refactor home state and fix loading progress #1499

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

mlykotom
Copy link
Contributor

@mlykotom mlykotom commented Nov 8, 2024

[Merge after #1498]

  • This PR merges the home UI state into one data class to be able to show loading state and content state at the same time.
  • It also fixes the progress to wait for the loading to finish.
  • Instead of circular progress, I switched to linear progress at the top of the content, which can indicate the work while showing content

After

after.mp4

Before

before.mp4

@mlykotom mlykotom requested a review from a team as a code owner November 8, 2024 09:18
@mlykotom mlykotom merged commit 9f2103f into main Nov 18, 2024
2 checks passed
@mlykotom mlykotom deleted the mlykotom/jetcaster/fix-progress branch November 18, 2024 09:09
mlykotom added a commit that referenced this pull request Nov 21, 2024
[Merge after #1499]
- it served only as a wrapper for parameters without any additional
logic
- it was unstable and creating new instance each composition, therefore
no skipping
- Reduces amount of passing and potentially making mistake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants